Re: [Patch mdadm] Add hot-unplug support to mdadm

[Doug Ledford <dledford@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1406 bytes --]

On 04/08/2010 08:33 PM, Neil Brown wrote:
> On Fri, 9 Apr 2010 09:31:53 +1000
> Neil Brown <neilb@suse.de> wrote:
> 
>> On Tue, 06 Apr 2010 22:02:58 -0400
>> Doug Ledford <dledford@redhat.com> wrote:
>>
>>> Let me know if you want me to redo/resend any of it.
>>>
>>
>> not necessary, but some remove would be appreciated.
>>
> I suspect you cope graciously with most of my typos, but this one is
> ridiculous!
> 
>    s/remove/review/
> 
> :-(

Yeah, that's when it transitions from typo to thinko.

> NeilBrown
> 
> P.S.  When could the word "remove" be used in that context?  The only excuse
> I can think of is that a "remove" is a palette cleanser at a banquet.
> So "some remove" would be "some crystallized fruit or ginger bread" - always
> appreciated :-)

Not sure how well that would travel across the pond unless it was
airmail ;-)

Initial review looks fine to me.  I think I would suggest a few more
tweaks to the default udev rules file, but I'll forward those
separately.  Later tonight I'll do actual unit testing of your patch to
make sure it doesn't regress any functionality and if it needs any
fixes, forward those on to you as well.

-- 
Doug Ledford <dledford@redhat.com>
              GPG KeyID: CFBFF194
	      http://people.redhat.com/dledford

Infiniband specific RPMs available at
	      http://people.redhat.com/dledford/Infiniband


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]