From: Jordan Russell <jr-list-2010@quo.to>
To: linux-raid@vger.kernel.org
Subject: Re: raid1.c read_balance() LBD issue?
Date: Fri, 07 May 2010 12:37:12 -0500 [thread overview]
Message-ID: <4BE44FC8.4010508@quo.to> (raw)
In-Reply-To: <4BD09399.4090901@quo.to>
On 4/22/2010 1:21 PM, I wrote:
> raid1.c's read_balance() function has:
>
> const unsigned long this_sector = r1_bio->sector;
>
> Doesn't that need to be:
>
> const sector_t this_sector = r1_bio->sector;
>
> for compatibility with LBD on 32-bit platforms?
Any comments on this?
At very least it appears the truncation to 32 bits will break the "disk
whose head is closest" logic.
--
Jordan Russell
next prev parent reply other threads:[~2010-05-07 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 18:21 raid1.c read_balance() LBD issue? Jordan Russell
2010-05-07 17:37 ` Jordan Russell [this message]
2010-05-07 22:22 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE44FC8.4010508@quo.to \
--to=jr-list-2010@quo.to \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).