From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tao Ma Subject: Re: [PATCH RESEND 1/2 block#for-linus] bio, fs: update READA and SWRITE to match the corresponding BIO_RW_* bits Date: Fri, 06 Aug 2010 12:04:43 +0800 Message-ID: <4C5B89DB.5050106@oracle.com> References: <20100628010346.GA2376@atlantis.cc.ndsu.nodak.edu> <4C28EFD6.2070203@vlnb.net> <20100714190325.GA25148@atlantis.cc.ndsu.nodak.edu> <4C3EF3AD.5070509@vlnb.net> <20100723191844.GB31152@atlantis.cc.ndsu.nodak.edu> <4C4D7DF5.9060909@vlnb.net> <20100727220110.GF31152@atlantis.cc.ndsu.nodak.edu> <4C5073F3.1060406@vlnb.net> <4C52A98A.7060507@kernel.org> <20100802104227.79340b49@notabene> <4C56D30A.3000403@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-raid-owner@vger.kernel.org To: Tejun Heo Cc: Jeff Moyer , Jens Axboe , stable@kernel.org, Vladislav Bolkhovitin , Bryan Mesich , scst-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, dm-devel@redhat.com, Neil Brown List-Id: linux-raid.ids Hi Tejun, On 08/06/2010 02:45 AM, Jeff Moyer wrote: > Tejun Heo writes: > >> Commit a82afdf (block: use the same failfast bits for bio and request) >> moved BIO_RW_* bits around such that they match up with REQ_* bits. >> Unfortunately, fs.h hard coded READ, WRITE, READA and SWRITE as 0, 1, >> 2 and 3, and expected them to match with BIO_RW_* bits. READ/WRITE >> didn't change but BIO_RW_AHEAD was moved to bit 4 instead of bit 1, >> breaking READA and SWRITE. >> >> This patch updates READA and SWRITE such that they match the BIO_RW_* >> bits again. A follow up patch will update the definitions to directly >> use BIO_RW_* bits so that this kind of breakage won't happen again. >> >> Stable: The offending commit a82afdf was released with v2.6.32, so >> this patch should be applied to all kernels since then but it must >> _NOT_ be applied to kernels earlier than that. If only this patch goes into stable, do we need to change RWA_MASK in this patch also(I have seen you change it the 2/2)? -#define RWA_MASK 2 +#define RWA_MASK 16 Regards, Tao