From: Jiri Slaby <jirislaby@gmail.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: neilb@suse.de, akpm@linux-foundation.org,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] MD: raid1, fix BUG caused by flags handling
Date: Thu, 12 Aug 2010 14:06:41 +0200 [thread overview]
Message-ID: <4C63E3D1.1010800@gmail.com> (raw)
In-Reply-To: <1281614465-2816-1-git-send-email-jslaby@suse.cz>
On 08/12/2010 02:01 PM, Jiri Slaby wrote:
> Commit 74450be1 (block: unify flags for struct bio and struct request)
Actually there are more than the two below introduced by the commit.
Hold on, I will post v2.
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -787,8 +787,8 @@ static int make_request(mddev_t *mddev, struct bio * bio)
> struct bio_list bl;
> struct page **behind_pages = NULL;
> const int rw = bio_data_dir(bio);
> - const bool do_sync = (bio->bi_rw & REQ_SYNC);
> - bool do_barriers;
> + const unsigned long do_sync = (bio->bi_rw & REQ_SYNC);
> + unsigned long do_barriers;
> mdk_rdev_t *blocked_rdev;
>
> /*
--
js
prev parent reply other threads:[~2010-08-12 12:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 12:01 [PATCH] MD: raid1, fix BUG caused by flags handling Jiri Slaby
2010-08-12 12:06 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C63E3D1.1010800@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).