From: Jiri Slaby <jirislaby@gmail.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: James Bottomley <James.Bottomley@suse.de>,
linux-scsi@vger.kernel.org, hch@lst.de, jaxboe@fusionio.com,
LKML <linux-kernel@vger.kernel.org>,
linux-raid@vger.kernel.org
Subject: Re: [BUG raid1] kernel BUG at drivers/scsi/scsi_lib.c:1113
Date: Wed, 18 Aug 2010 00:13:18 +0200 [thread overview]
Message-ID: <4C6B097E.7060505@gmail.com> (raw)
In-Reply-To: <20100817220917.GA5268@Krystal>
On 08/18/2010 12:09 AM, Mathieu Desnoyers wrote:
> This is with these changes applied:
Hi, these are very wrong. Please use ones from:
http://lkml.org/lkml/2010/8/12/98
(there are three of them)
> --- linux.trees.git.orig/drivers/md/raid1.c 2010-08-17 17:40:52.000000000 -0400
> +++ linux.trees.git/drivers/md/raid1.c 2010-08-17 17:42:59.000000000 -0400
> @@ -787,7 +787,7 @@ static int make_request(mddev_t *mddev,
> struct bio_list bl;
> struct page **behind_pages = NULL;
> const int rw = bio_data_dir(bio);
> - const bool do_sync = (bio->bi_rw & REQ_SYNC);
> + const bool do_sync = (bio->bi_rw & REQ_SYNC) != 0;
> bool do_barriers;
> mdk_rdev_t *blocked_rdev;
>
...
regards,
--
js
next prev parent reply other threads:[~2010-08-17 22:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-17 22:09 [BUG raid1] kernel BUG at drivers/scsi/scsi_lib.c:1113 Mathieu Desnoyers
2010-08-17 22:13 ` Jiri Slaby [this message]
2010-08-17 22:31 ` Mathieu Desnoyers
2010-08-18 11:42 ` Jiri Slaby
2010-08-18 14:32 ` James Bottomley
2010-08-18 14:36 ` Jiri Slaby
2010-08-18 14:41 ` James Bottomley
2010-08-18 21:49 ` Jens Axboe
2010-08-18 22:50 ` James Bottomley
2010-08-19 2:59 ` Jens Axboe
2010-08-19 14:52 ` James Bottomley
2010-08-23 9:01 ` Jens Axboe
2010-08-23 17:08 ` James Bottomley
2010-08-23 17:18 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6B097E.7060505@gmail.com \
--to=jirislaby@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=hch@lst.de \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).