From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Subject: Re: [BUG raid1] kernel BUG at drivers/scsi/scsi_lib.c:1113 Date: Wed, 18 Aug 2010 00:13:18 +0200 Message-ID: <4C6B097E.7060505@gmail.com> References: <20100817220917.GA5268@Krystal> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100817220917.GA5268@Krystal> Sender: linux-scsi-owner@vger.kernel.org To: Mathieu Desnoyers Cc: James Bottomley , linux-scsi@vger.kernel.org, hch@lst.de, jaxboe@fusionio.com, LKML , linux-raid@vger.kernel.org List-Id: linux-raid.ids On 08/18/2010 12:09 AM, Mathieu Desnoyers wrote: > This is with these changes applied: Hi, these are very wrong. Please use ones from: http://lkml.org/lkml/2010/8/12/98 (there are three of them) > --- linux.trees.git.orig/drivers/md/raid1.c 2010-08-17 17:40:52.000000000 -0400 > +++ linux.trees.git/drivers/md/raid1.c 2010-08-17 17:42:59.000000000 -0400 > @@ -787,7 +787,7 @@ static int make_request(mddev_t *mddev, > struct bio_list bl; > struct page **behind_pages = NULL; > const int rw = bio_data_dir(bio); > - const bool do_sync = (bio->bi_rw & REQ_SYNC); > + const bool do_sync = (bio->bi_rw & REQ_SYNC) != 0; > bool do_barriers; > mdk_rdev_t *blocked_rdev; > ... regards, -- js