From: Avi Kivity <avi@redhat.com>
To: Neil Brown <neilb@suse.de>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Kulikov Vasiliy <segooon@gmail.com>,
kernel-janitors@vger.kernel.org, Jens Axboe <jaxboe@fusionio.com>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] md: do not use ++ in rcu_dereference() argument
Date: Thu, 16 Sep 2010 14:54:29 +0200 [thread overview]
Message-ID: <4C921385.2080205@redhat.com> (raw)
In-Reply-To: <20100906152931.1d4a1d07@notabene>
On 09/06/2010 08:29 AM, Neil Brown wrote:
> I've taken the opportunity to substantially re-write that code.
>
>
It's better to have two patches, one a backportable one liner that fixes
the bug, the other, on top, that cleans up the code but has no sematic
changes.
This makes it substantially easier to review. When considering the
first patch you see the change plainly. When reviewing the second patch
you make sure no semantic changes were made at all.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-09-16 12:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-05 18:32 [PATCH] md: do not use ++ in rcu_dereference() argument Kulikov Vasiliy
2010-09-05 19:01 ` Sam Ravnborg
2010-09-05 19:23 ` Kulikov Vasiliy
2010-09-05 20:39 ` Sam Ravnborg
2010-09-06 5:29 ` Neil Brown
2010-09-06 7:43 ` walter harms
2010-09-06 11:05 ` Neil Brown
2010-09-06 19:21 ` Sam Ravnborg
2010-09-08 7:04 ` Neil Brown
2010-09-16 12:54 ` Avi Kivity [this message]
2010-09-17 3:18 ` Neil Brown
2010-09-06 20:10 ` Arnd Bergmann
2010-09-07 19:21 ` Kulikov Vasiliy
2010-09-07 20:00 ` Arnd Bergmann
2010-09-07 20:50 ` Paul E. McKenney
2010-09-09 15:14 ` Arnd Bergmann
2010-09-10 3:46 ` Paul E. McKenney
2010-09-14 0:33 ` Paul E. McKenney
2010-09-15 12:28 ` Arnd Bergmann
2010-09-16 6:15 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C921385.2080205@redhat.com \
--to=avi@redhat.com \
--cc=jaxboe@fusionio.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=sam@ravnborg.org \
--cc=segooon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).