From: Dan Williams <dan.j.williams@intel.com>
To: "Czarnowska, Anna" <anna.czarnowska@intel.com>
Cc: Neil Brown <neilb@suse.de>,
"Neubauer, Wojciech" <Wojciech.Neubauer@intel.com>,
"Ciechanowski, Ed" <ed.ciechanowski@intel.com>,
"Labun, Marcin" <Marcin.Labun@intel.com>,
"Hawrylewicz Czarnowski,
Przemyslaw" <przemyslaw.hawrylewicz.czarnowski@intel.com>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>
Subject: Re: [PATCH 05/17] Util: get device size from id
Date: Thu, 04 Nov 2010 22:42:30 -0700 [thread overview]
Message-ID: <4CD39946.5000809@intel.com> (raw)
In-Reply-To: <A9DE54D0CD747C4CB06DCE5B6FA2246F010BAF0FBF@irsmsx504.ger.corp.intel.com>
On 10/29/2010 7:19 AM, Czarnowska, Anna wrote:
> From c0bbe01f5f73d123af899338e838d45df1a4abee Mon Sep 17 00:00:00 2001
> From: Anna Czarnowska<anna.czarnowska@intel.com>
> Date: Fri, 22 Oct 2010 13:23:15 +0200
> Subject: [PATCH 05/17] Util: get device size from id
>
> Signed-off-by: Anna Czarnowska<anna.czarnowska@intel.com>
> ---
> mdadm.h | 1 +
> util.c | 18 ++++++++++++++++++
> 2 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/mdadm.h b/mdadm.h
> index 450fb11..66363fb 100644
> --- a/mdadm.h
> +++ b/mdadm.h
> @@ -745,6 +745,7 @@ static inline struct supertype *guess_super(int fd) {
> }
> extern struct supertype *dup_super(struct supertype *st);
> extern int get_dev_size(int fd, char *dname, unsigned long long *sizep);
> +extern int dev_size_from_id(unsigned id, unsigned long long *size);
Small nits:
id should be dev_t.
...and this patch should be squashed into the patch that uses it.
prev parent reply other threads:[~2010-11-05 5:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 14:19 [PATCH 05/17] Util: get device size from id Czarnowska, Anna
2010-11-05 5:42 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CD39946.5000809@intel.com \
--to=dan.j.williams@intel.com \
--cc=Marcin.Labun@intel.com \
--cc=Wojciech.Neubauer@intel.com \
--cc=anna.czarnowska@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=przemyslaw.hawrylewicz.czarnowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).