From: Dan Williams <dan.j.williams@intel.com>
To: "Labun, Marcin" <Marcin.Labun@intel.com>,
"Kwolek, Adam" <adam.kwolek@intel.com>
Cc: Neil Brown <neilb@suse.de>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"Neubauer, Wojciech" <Wojciech.Neubauer@intel.com>,
"Czarnowska, Anna" <anna.czarnowska@intel.com>,
"Ciechanowski, Ed" <ed.ciechanowski@intel.com>,
"Hawrylewicz Czarnowski,
Przemyslaw" <przemyslaw.hawrylewicz.czarnowski@intel.com>
Subject: Re: [PATCH 2/2] IMSM: do not rebuild the array if a non-redundant sub-array with failed disks is present
Date: Wed, 08 Dec 2010 09:48:28 -0800 [thread overview]
Message-ID: <4CFFC4EC.8090100@intel.com> (raw)
In-Reply-To: <905EDD02F158D948B186911EB64DB3D17676EB3F@irsmsx503.ger.corp.intel.com>
>> This seems to imply that there are only ever at most 2 volumes in a
>> container. Is that really true? The rest of the code seems to assume
>> that
>> there could be several.
>
>
> There are at most two sub-array in one array.
Empirically to date yes, but...
This is an arbitrary restriction imposed by the orom, it could be
changed in future versions and it is not enforced when setting the
IMSM_NO_PLATFORM variable.
When coding for "more than 1" it is not much more effort to code for
"infinite". This approach helped find bugs in the implementation/usage
of reserve_space() that would not have triggered if the tests
(tests/08imsm-overlap) were hardcoded for at most 2 arrays.
So the implementation should handle the case when imsm_orom.vpa > 2 or
IMSM_NO_PLATFORM == 1.
--
Dan
prev parent reply other threads:[~2010-12-08 17:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 16:10 [PATCH 2/2] IMSM: do not rebuild the array if a non-redundant sub-array with failed disks is present Labun, Marcin
2010-12-08 2:32 ` Neil Brown
2010-12-08 14:48 ` Labun, Marcin
2010-12-08 14:59 ` Labun, Marcin
2010-12-08 17:48 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFFC4EC.8090100@intel.com \
--to=dan.j.williams@intel.com \
--cc=Marcin.Labun@intel.com \
--cc=Wojciech.Neubauer@intel.com \
--cc=adam.kwolek@intel.com \
--cc=anna.czarnowska@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=przemyslaw.hawrylewicz.czarnowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).