From: Dan Williams <dan.j.williams@intel.com>
To: "Kwolek, Adam" <adam.kwolek@intel.com>
Cc: "neilb@suse.de" <neilb@suse.de>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"Neubauer, Wojciech" <Wojciech.Neubauer@intel.com>,
"Ciechanowski, Ed" <ed.ciechanowski@intel.com>
Subject: Re: open_dev_excl in reshape_container() fails
Date: Fri, 14 Jan 2011 14:49:43 -0800 [thread overview]
Message-ID: <4D30D307.6030602@intel.com> (raw)
In-Reply-To: <905EDD02F158D948B186911EB64DB3D176E5A6CF@irsmsx503.ger.corp.intel.com>
On 1/14/2011 2:36 AM, Kwolek, Adam wrote:
> Hi,
>
> I think I've found problem root cause.
> As I'm working on "Online Capacity Expansion", my tests uses mounted arrays - this is in conflict with open_dev_ext()
> and fails this function. Evrything is ok This means that reshape operation cannot be performed online (or this is valid on my system only?).
>
> I do not know why on begin (in main() of mdadm.c) this function can succeed and later not (later system blocks array ?).
> More, when I've made some open_dev_exe()+close() earlier, it works later also (please look used code below/treat patch as demo/).
>
> Summarizing problem is related to mounted arrays only.
Why do we need an exclusive open on the subarrays, that defeats the
purpose of online capacity expansion? The exclusive open on the
container prevents new arrays from being created and other races, but I
do not see why we would need exclusive access to the subarray.
I would look at the code, but I am distracted by another firefight at
the moment.
--
Dan
next prev parent reply other threads:[~2011-01-14 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 15:40 open_dev_excl in reshape_container() fails Kwolek, Adam
2011-01-13 17:27 ` Dan Williams
2011-01-14 7:31 ` Kwolek, Adam
2011-01-14 10:36 ` Kwolek, Adam
2011-01-14 22:49 ` Dan Williams [this message]
2011-01-17 4:07 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D30D307.6030602@intel.com \
--to=dan.j.williams@intel.com \
--cc=Wojciech.Neubauer@intel.com \
--cc=adam.kwolek@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).