From: Milan Broz <mbroz@redhat.com>
To: NeilBrown <neilb@suse.de>
Cc: Namhyung Kim <namhyung@gmail.com>, linux-raid@vger.kernel.org
Subject: Re: [PATCH] mdadm: Linux 3.x version change
Date: Fri, 17 Jun 2011 14:18:47 +0200 [thread overview]
Message-ID: <4DFB4627.7050809@redhat.com> (raw)
In-Reply-To: <1307716200-27483-1-git-send-email-namhyung@gmail.com>
On 06/10/2011 04:30 PM, Namhyung Kim wrote:
> As Linux 3.x changes its versioning scheme, we have to deal with
> the 2-digit version number also.
FYI: we have patch below currently in Fedora rawhide
(which already switched to 3.0-rc numbering scheme).
Without it is system unable to assembly RAID during boot
("mdadm -As --auto=yes --run" fails because of wrong version detected).
It seems that 3.2.2 still have the same problem.
Milan
--- mdadm-3.2.1.old/util.c 2011-03-28 04:31:20.000000000 +0200
+++ mdadm-3.2.1/util.c 2011-06-05 07:59:03.741904751 +0200
@@ -154,8 +154,8 @@ int get_linux_version()
a = strtoul(cp, &cp, 10);
if (*cp != '.') return -1;
b = strtoul(cp+1, &cp, 10);
- if (*cp != '.') return -1;
- c = strtoul(cp+1, NULL, 10);
+ if (*cp != '.' && a <= 2) return -1;
+ c = (*cp == '.') ? strtoul(cp+1, NULL, 10) : 0;
return (a*1000000)+(b*1000)+c;
}
next prev parent reply other threads:[~2011-06-17 12:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 14:30 [PATCH] mdadm: Linux 3.x version change Namhyung Kim
2011-06-17 12:18 ` Milan Broz [this message]
2011-06-17 12:54 ` NeilBrown
2011-06-17 14:07 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFB4627.7050809@redhat.com \
--to=mbroz@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).