From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 2/2] block: remove support for bio remapping from ->make_request Date: Mon, 12 Sep 2011 11:59:52 +0200 Message-ID: <4E6DD818.80902@kernel.dk> References: <20110911145053.GA28996@infradead.org> <20110911145129.GA29504@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110911145129.GA29504@infradead.org> Sender: linux-kernel-owner@vger.kernel.org To: Christoph Hellwig Cc: linux-raid@vger.kernel.org, dm-devel@redhat.com, linux-kernel@vger.kernel.org List-Id: linux-raid.ids On 2011-09-11 16:51, Christoph Hellwig wrote: > There is very little benefit in allowing to let a ->make_request > instance update the bios device and sector and loop around it in > __generic_make_request when we can archive the same through calling > generic_make_request from the driver and letting the loop in > generic_make_request handle it. Agree, this looks good! Will apply for 3.2. > Note that various drivers got the return value from ->make_request and > returned non-zero values for errors. Hadn't noticed that, I guess the return values are easy to get wrong in that case. Never a good sign. -- Jens Axboe