From: Michal Soltys <soltys@ziu.info>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] udev rules: use $tempnode, check for supported types, comments
Date: Mon, 19 Sep 2011 09:23:01 +0200 [thread overview]
Message-ID: <4E76EDD5.4000605@ziu.info> (raw)
In-Reply-To: <20110919131250.070a5002@notabene.brown>
W dniu 19.09.2011 05:12, NeilBrown pisze:
>
> Thanks.
> I've applied this... though I must admit that I don't really like all the
> GOTOs - but that is really the fault of udev I expect.
>
Yes, well - the alternative is a single bit longer line such as:
ENV{ID_FS_TYPE}!="ddf_raid_member", ENV{ID_FS_TYPE}!="isw_raid_member", ENV{ID_FS_TYPE}!="linux_raid_member", GOTO="md_inc_skip"
I thought the version with one more goto was more readable in the end,
though I also have my doubts about the choice.
> What was the rational for changing
> ==""
> to
> !="?*"
>
> ??
>
Actually none, just happened during the rewrite (both alternatives
are functionally identical) - I guess I'm more used to "?*" checks
for "is / isn't defined", so I didn't pay attention for it to be
exact like before.
prev parent reply other threads:[~2011-09-19 7:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-04 12:42 [PATCH 0/2] udev rules behaviour Michal Soltys
2011-09-04 12:42 ` [PATCH 1/2] udev rules: don't incrementally autoassemble everything Michal Soltys
2011-09-04 12:42 ` [PATCH 2/2] shorten remove rules Michal Soltys
2011-09-06 21:39 ` v2 - keep incremental, check types Michal Soltys
2011-09-06 21:39 ` [PATCH] udev rules: add ddf, shorten checks, use $tempnode Michal Soltys
2011-09-07 4:00 ` [PATCH 0/2] udev rules behaviour NeilBrown
2011-09-08 7:25 ` v2 once more, for current head Michal Soltys
2011-09-08 7:25 ` [PATCH] udev rules: use $tempnode, check for supported types, comments Michal Soltys
2011-09-19 3:12 ` NeilBrown
2011-09-19 7:23 ` Michal Soltys [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E76EDD5.4000605@ziu.info \
--to=soltys@ziu.info \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).