From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, dledford@redhat.com
Subject: Re: [PATCH 1/3] conf_match(): Remove dead code
Date: Tue, 01 Nov 2011 07:22:45 +0100 [thread overview]
Message-ID: <4EAF9035.30407@redhat.com> (raw)
In-Reply-To: <20111101133331.21d4ebae@notabene.brown>
On 11/01/11 03:33, NeilBrown wrote:
> Hi Jes,
> thanks for these 3 patches.
> In each case I chose to remove different code :-)
>
> In this case search_mdstat was nearly identical to conf_match, but uses the
> bits you removed. So I unified the two.
>
> For the 'Kill' fix, I removed a different test on 'force' so that the printf
> that you removed could not actually be reached.
That is great! There are times where I am not quite sure what the
original intention of the code was, so I am just glad the patches is
proving to be of use :)
Cheers,
Jes
next prev parent reply other threads:[~2011-11-01 6:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-31 13:53 [PATCH 0/3] Remove dead code Jes.Sorensen
2011-10-31 13:53 ` [PATCH 1/3] conf_match(): " Jes.Sorensen
2011-11-01 2:33 ` NeilBrown
2011-11-01 6:22 ` Jes Sorensen [this message]
2011-10-31 13:53 ` [PATCH 2/3] conf_watch(): More dead code removal Jes.Sorensen
2011-10-31 13:53 ` [PATCH 3/3] Kill(): Remove redundant check and dead code Jes.Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EAF9035.30407@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=dledford@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).