Re: [PATCH v2 0/4] add --preboot argument to mdadm/mdmon

[Doug Ledford <dledford@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2890 bytes --]

On 01/23/2012 11:39 AM, Jes Sorensen wrote:
> On 01/23/12 17:24, Doug Ledford wrote:
>> On 01/23/2012 06:18 AM, Jes.Sorensen@redhat.com wrote:
>>>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>>>
>>>> Hi,
>>>>
>>>> Here is v2 of the systemd/dracut fixes for preboot handling in
>>>> mdadm/mdmon. I have changed the argument over from --initrd to
>>>> --preboot as Neil suggested, as well as fixed up the minor code nits
>>>> and added documentation to the man pages.
>>>>
>>>> It shows up that I didn't need to add a separate enum for the command
>>>> line arguments in mdmon since mdadm.h gets pulled in so we can reuse
>>>> those. If we find that to be an issue, we can always create a separate
>>>> one later.
>> I'm not sure I like --preboot.  I understand the difficulty in finding
>> just the right option name, but to me, preboot sounds like an option you
>> would use if you are doing pre-processing of something for a later
>> invokation to use.  And that isn't the case here, so the gut level
>> understanding won't match up with the man page/help output understanding
>> and I try to avoid that as much as possible.  Since the distinct element
>> is that we want to keep running both before and after the normal root
>> filesystem is mounted and we want all files we open to be off of the
>> root filesystem namespace, maybe --offroot (which is odd enough by
>> itself to forestall any gut reactions and prompt a trip to the help/man
>> pages as opposed to guessing what the option means)?
>>
> 
> Kay suggested --preroot on irc - would that do the job? I think that is
> a bit better than --offroot.

I'd say preroot is better than preboot for sure.  I think I still like
offroot more than preroot though.  We *are* running off root (from the
initramfs, and we are modifying our argv[0] to signal to systemd that we
are doing exactly this).  We *are* keeping our files off of root (in
/run/mdadm versus /var/run/mdadm).  And we are intending to live both
before root (preroot) and also after root (postroot).  So, I find
preroot to be better than preboot, but still not as accurate as offroot.
 Offroot fairly accurately captures what we are doing (although it
doesn't speak to the expected life span of the action, nor does it speak
to the fact that we stay off root only if we are invoked from what will
become the non-root fs, so some sort of check to make sure we are
actually in an initrd/initramfs of sorts might be nice, but I'm not sure
how that would play with things like USB live images where you might
actually want to use the option on a non-initrd environment), where as
both preboot and preroot speak as to when it is used, but not what it
does nor the expected life span of the action.


-- 
Doug Ledford <dledford@redhat.com>
              GPG KeyID: 0E572FDD
	      http://people.redhat.com/dledford



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]