From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Doug Ledford <dledford@redhat.com>
Cc: neilb@suse.de, linux-raid@vger.kernel.org, kay@redhat.com,
harald@redhat.com, lpoetter@redhat.com, mschmidt@redhat.com
Subject: Re: [PATCH v2 0/4] add --preboot argument to mdadm/mdmon
Date: Mon, 23 Jan 2012 19:05:32 +0100 [thread overview]
Message-ID: <4F1DA16C.7030202@redhat.com> (raw)
In-Reply-To: <4F1D905C.1050300@redhat.com>
On 01/23/12 17:52, Doug Ledford wrote:
>> Kay suggested --preroot on irc - would that do the job? I think that is
>> > a bit better than --offroot.
> I'd say preroot is better than preboot for sure. I think I still like
> offroot more than preroot though. We *are* running off root (from the
> initramfs, and we are modifying our argv[0] to signal to systemd that we
> are doing exactly this). We *are* keeping our files off of root (in
> /run/mdadm versus /var/run/mdadm). And we are intending to live both
> before root (preroot) and also after root (postroot). So, I find
> preroot to be better than preboot, but still not as accurate as offroot.
> Offroot fairly accurately captures what we are doing (although it
> doesn't speak to the expected life span of the action, nor does it speak
> to the fact that we stay off root only if we are invoked from what will
> become the non-root fs, so some sort of check to make sure we are
> actually in an initrd/initramfs of sorts might be nice, but I'm not sure
> how that would play with things like USB live images where you might
> actually want to use the option on a non-initrd environment), where as
> both preboot and preroot speak as to when it is used, but not what it
> does nor the expected life span of the action.
Ok, I guess it depends a bit on how one thinks of it, ie. whether
thinking in the context of how it was launched or the system state. I am
not really biased one way or another, I mostly care about the
functionality, so I am going to wait until tomorrow and see what other
input we get and what Neil has to say.
Once we have a consensus, I'll cook up a v3 of the patches to match that.
Cheers,
Jes
next prev parent reply other threads:[~2012-01-23 18:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 11:18 [PATCH v2 0/4] add --preboot argument to mdadm/mdmon Jes.Sorensen
2012-01-23 11:18 ` [PATCH 1/4] mdmon: Use getopt_long() to parse command line options Jes.Sorensen
2012-01-23 11:18 ` [PATCH 2/4] Add --preboot argument to mdadm Jes.Sorensen
2012-01-23 11:18 ` [PATCH 3/4] Add --preboot argument to mdmon Jes.Sorensen
2012-01-23 11:18 ` [PATCH 4/4] Spawn mdmon with --preboot if mdadm was launched with --preboot Jes.Sorensen
2012-01-23 16:24 ` [PATCH v2 0/4] add --preboot argument to mdadm/mdmon Doug Ledford
2012-01-23 16:39 ` Jes Sorensen
2012-01-23 16:52 ` Doug Ledford
2012-01-23 17:04 ` John Robinson
2012-01-23 18:05 ` Jes Sorensen [this message]
2012-01-23 17:04 ` Krzysztof Adamski
2012-01-23 20:52 ` Lennart Poettering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1DA16C.7030202@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=dledford@redhat.com \
--cc=harald@redhat.com \
--cc=kay@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=lpoetter@redhat.com \
--cc=mschmidt@redhat.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).