From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, dledford@redhat.com, kay@redhat.com,
harald@redhat.com, lpoetter@redhat.com, mschmidt@redhat.com
Subject: Re: [PATCH 4/4] Spawn mdmon with --offroot if mdadm was launched with --offroot
Date: Mon, 30 Jan 2012 10:06:00 +0100 [thread overview]
Message-ID: <4F265D78.60006@redhat.com> (raw)
In-Reply-To: <20120130121036.09243aa0@notabene.brown>
On 01/30/12 02:10, NeilBrown wrote:
>> @@ -1622,10 +1624,17 @@ int start_mdmon(int devnum)
>> > skipped = 0;
>> >
>> > for (i=0; paths[i]; i++)
>> > - if (paths[i][0])
>> > - execl(paths[i], "mdmon",
>> > - devnum2devname(devnum),
>> > - NULL);
>> > + if (paths[i][0]) {
>> > + if (__offroot) {
>> > + execl(paths[i], "mdmon", "--offroot",
>> > + devnum2devname(devnum),
>> > + NULL);
> I just occurred to me that this could be:
>
> execl(paths[i], "@mdmon", devnum2devname(devnum));
>
> which seems simpler... but I'll leave it as it is.
Hadn't thought of that :)
> All applied - thanks.
Excellent, will you be able to push it out today? As soon as I see it in
your git repo, I will push it into Fedora rawhide so we can get it tested.
Cheers,
Jes
next prev parent reply other threads:[~2012-01-30 9:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 15:18 [PATCH v3 0/4] add --offroot argument to mdadm/mdmon Jes.Sorensen
2012-01-25 15:18 ` [PATCH 1/4] mdmon: Use getopt_long() to parse command line options Jes.Sorensen
2012-01-25 15:18 ` [PATCH 2/4] Add --offroot argument to mdadm Jes.Sorensen
2012-01-25 15:18 ` [PATCH 3/4] Add --offroot argument to mdmon Jes.Sorensen
2012-01-25 15:18 ` [PATCH 4/4] Spawn mdmon with --offroot if mdadm was launched with --offroot Jes.Sorensen
2012-01-30 1:10 ` NeilBrown
2012-01-30 9:06 ` Jes Sorensen [this message]
2012-01-25 16:02 ` [PATCH v3 0/4] add --offroot argument to mdadm/mdmon Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F265D78.60006@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=dledford@redhat.com \
--cc=harald@redhat.com \
--cc=kay@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=lpoetter@redhat.com \
--cc=mschmidt@redhat.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).