From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jes Sorensen Subject: Re: [PATCH 0/1] Make failure message on re-add more explcit Date: Thu, 23 Feb 2012 09:34:34 +0100 Message-ID: <4F45FA1A.2020706@redhat.com> References: <1329930000-20679-1-git-send-email-Jes.Sorensen@redhat.com> <20120223090412.2b14fb7f@notabene.brown> <4F457758.8060807@redhat.com> <4F459D05.5060104@anonymous.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F459D05.5060104@anonymous.org.uk> Sender: linux-raid-owner@vger.kernel.org To: John Robinson Cc: NeilBrown , linux-raid@vger.kernel.org List-Id: linux-raid.ids On 02/23/12 02:57, John Robinson wrote: > On 22/02/2012 23:16, Jes Sorensen wrote: > [...] >> The goal was to try and reduce the number of bug reports over this by >> making it more obvious/explicit, so if you have a suggestion for how to >> do so in a better way, I am all game. > > How about: > > mdadm /dev/md0 --add %s > : %s was already a member of /dev/md0, attempting re-add > : Re-add failed because > : Not performing add as that would zero the superblock on %s and make it > a spare > : mdadm --add used to do that automatically but it was potentially > dangerous > : If that is what you really want to do, use mdadm --zero-superblock %s > first. > This would get my vote, way better than my messy attempt. Cheers, Jes