linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shaohua Li <shli@kernel.org>
To: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>
Cc: "neilb@suse.de" <neilb@suse.de>
Subject: [patch]raid5: remove unused variables
Date: Tue, 17 Apr 2012 13:09:26 +0800	[thread overview]
Message-ID: <4F8CFB06.4090908@kernel.org> (raw)


The two variables are useless.

Signed-off-by: Shaohua Li <shli@fusionio.com>
---
  drivers/md/raid5.c |    4 ----
  1 file changed, 4 deletions(-)

Index: linux/drivers/md/raid5.c
===================================================================
--- linux.orig/drivers/md/raid5.c	2012-04-17 11:56:16.606009690 +0800
+++ linux/drivers/md/raid5.c	2012-04-17 11:57:47.026009295 +0800
@@ -3953,12 +3953,10 @@ static void make_request(struct mddev *m
  	plugged = mddev_check_plugged(mddev);
  	for (;logical_sector < last_sector; logical_sector += STRIPE_SECTORS) {
  		DEFINE_WAIT(w);
-		int disks, data_disks;
  		int previous;

  	retry:
  		previous = 0;
-		disks = conf->raid_disks;
  		prepare_to_wait(&conf->wait_for_overlap, &w, TASK_UNINTERRUPTIBLE);
  		if (unlikely(conf->reshape_progress != MaxSector)) {
  			/* spinlock is needed as reshape_progress may be
@@ -3973,7 +3971,6 @@ static void make_request(struct mddev *m
  			if (mddev->delta_disks < 0
  			    ? logical_sector < conf->reshape_progress
  			    : logical_sector >= conf->reshape_progress) {
-				disks = conf->previous_raid_disks;
  				previous = 1;
  			} else {
  				if (mddev->delta_disks < 0
@@ -3986,7 +3983,6 @@ static void make_request(struct mddev *m
  			}
  			spin_unlock_irq(&conf->device_lock);
  		}
-		data_disks = disks - conf->max_degraded;

  		new_sector = raid5_compute_sector(conf, logical_sector,
  						  previous,

             reply	other threads:[~2012-04-17  5:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-17  5:09 Shaohua Li [this message]
2012-04-17  6:36 ` [patch]raid5: remove unused variables NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F8CFB06.4090908@kernel.org \
    --to=shli@kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).