From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: NeilBrown <neilb@suse.de>
Cc: dledford@redhat.com, linux-raid@vger.kernel.org
Subject: Re: [PATCH 4/4] Move setup code to a function and introduce matching cleanup argument
Date: Tue, 29 May 2012 08:02:16 +0200 [thread overview]
Message-ID: <4FC46668.9070306@redhat.com> (raw)
In-Reply-To: <20120528105641.7dd20b5f@notabene.brown>
On 05/28/12 02:56, NeilBrown wrote:
> On Fri, 25 May 2012 17:24:08 +0200 Jes.Sorensen@redhat.com wrote:
>
>> @@ -231,7 +233,7 @@ do_test() {
>> if [ "$savelogs" == "1" ]; then
>> cp $targetdir/log $logdir/$_basename.log
>> fi
>> - if [ "$_fail" == "1" -a $"exitonerror" == "1" ]; then
>> + if [ "$_fail" == "1" -a "$exitonerror" == "1" ]; then
>> exit 1
>> fi
>> fi
>
> I merged this fix back into the previous patch that introduced the bug :-)
>
> Otherwise - all applied,
> Thanks.
Sounds good!
> I'll definitely be using the --no-error option!
Excellent, glad it's turning out to be useful. I am trying to get to a
point where I can have the test suite run automatically, though I am
still hitting test errors on both Fedora and RHEL at this point which I
need to figure out first.
Cheers,
Jes
prev parent reply other threads:[~2012-05-29 6:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-25 15:24 [PATCH 0/4] More test suite enchancements Jes.Sorensen
2012-05-25 15:24 ` [PATCH 1/4] Add support for saving log files in test script Jes.Sorensen
2012-05-28 0:54 ` NeilBrown
2012-05-25 15:24 ` [PATCH 2/4] Add --no-error argument to 'test' Jes.Sorensen
2012-05-25 15:24 ` [PATCH 3/4] Improve --help message from test Jes.Sorensen
2012-05-25 15:24 ` [PATCH 4/4] Move setup code to a function and introduce matching cleanup argument Jes.Sorensen
2012-05-28 0:56 ` NeilBrown
2012-05-29 6:02 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC46668.9070306@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=dledford@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).