linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Fengguang Wu <wfg@linux.intel.com>
Cc: linux-scsi@vger.kernel.org, linux-raid@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: drivers/block/cpqarray.c:938:2: error: too many arguments to function 慴lk_rq_map_sg�
Date: Thu, 14 Jun 2012 11:05:33 +0200	[thread overview]
Message-ID: <4FD9A95D.40903@kernel.dk> (raw)
In-Reply-To: <20120614090151.GA12013@localhost>

On 06/14/2012 11:01 AM, Fengguang Wu wrote:
> Hi Jens,
> 
> On Thu, Jun 14, 2012 at 08:30:11AM +0200, Jens Axboe wrote:
>> On 06/14/2012 01:03 AM, wfg@linux.intel.com wrote:
>>> FYI, kernel build failed on
>>>
>>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git multiqueue
>>> head:   e9a6aa8a0b7b93195774a9fcf551632bf3abcd97
>>> commit: 67db7275fa4325d46853a4bfcb79acf32e48eca8 [1/3] multiqueue: a hodge podge of things
>>
>> The multiqueue branch is a private branch, it's known broken on many
>> configs at the moment.
> 
> OK. Sorry my script just blindly build tests every new/updated branches
> in the tree. It does try to reduce noise level by remembering all warned
> error messages. However if it still presents a problem to the private
> branches, I can either explicitly blacklist "multiqueue", or let the
> script automatically skip commits whose "^Signed-off-by:" is still missing.

It's not a problem that you're building various branches, as long as you
are expecting a bit of noise :-). In fact I applaud your effort on
expanding the scope of building others branches.

But it does raise the question of how do we best signal intermediate
branches like this, so they can be avoided until they are ready. The
blacklist doesn't seem like a great choice, since then I have to
remember to remind you when it _is_ ok to build it.

How about some arbitrary tag? Instead of checking a Signed-off-by, I
could just add a Dont-Auto-Build or something like that. What do you
think?

-- 
Jens Axboe


  reply	other threads:[~2012-06-14  9:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-13 23:03 drivers/block/cpqarray.c:938:2: error: too many arguments to function ‘blk_rq_map_sg’ wfg
2012-06-14  6:30 ` Jens Axboe
2012-06-14  9:01   ` drivers/block/cpqarray.c:938:2: error: too many arguments to function 慴lk_rq_map_sg� Fengguang Wu
2012-06-14  9:05     ` Jens Axboe [this message]
2012-06-14  9:25       ` Fengguang Wu
2012-06-14 17:26         ` Junio C Hamano
2012-06-14 10:02       ` drivers/block/cpqarray.c:938:2: error: too many arguments to function lk_rq_map_sg Fengguang Wu
2012-06-14 10:45         ` Jens Axboe
2012-06-14 11:31           ` Fengguang Wu
2012-06-14 11:52             ` Tomas Carnecky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD9A95D.40903@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wfg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).