public inbox for linux-raid@vger.kernel.org
 help / color / mirror / Atom feed
From: Guoqing Jiang <jgq516@gmail.com>
To: Song Liu <song@kernel.org>, Guoqing Jiang <jgq516@gmail.com>
Cc: linux-raid <linux-raid@vger.kernel.org>,
	Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V3 2/8] md: add io accounting for raid0 and raid5
Date: Thu, 27 May 2021 14:33:44 +0800	[thread overview]
Message-ID: <4fb81639-2f1b-9acd-4d81-37d9817fd89b@gmail.com> (raw)
In-Reply-To: <CAPhsuW7hj1pRN8tPLPMr0YGaMG0z5-EKztqoph7sALrW4c+4bA@mail.gmail.com>

Hi Song,

On 5/27/21 2:14 PM, Song Liu wrote:
>> Could you point the place where md enables iostats before the set?
>> I can't find relevant code for it.
> Before this set, we did not set QUEUE_FLAG_IO_STAT, and we didn't
> check blk_queue_io_stat() either. So even with /sys/block/mdX/queue/iostats
> of 0, we still get iostats for the md device. By setting QUEUE_FLAG_IO_STAT
> with the patch, the users still get iostats working by default.

I am okay with enable it by default,  though users need to know the
parameter given it affects the performance.

Thanks,
Guoqing

  reply	other threads:[~2021-05-27  6:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-25  9:46 [PATCH V3 0/6] md: io stats accounting Guoqing Jiang
2021-05-25  9:46 ` [PATCH V3 1/8] md: revert " Guoqing Jiang
2021-05-25  9:46 ` [PATCH V3 2/8] md: add io accounting for raid0 and raid5 Guoqing Jiang
2021-05-26  6:32   ` Song Liu
2021-05-26  7:53     ` Guoqing Jiang
2021-05-26 16:00       ` Song Liu
2021-05-27  2:00         ` Guoqing Jiang
2021-05-27  6:14           ` Song Liu
2021-05-27  6:33             ` Guoqing Jiang [this message]
2021-05-27 15:25   ` Christoph Hellwig
2021-05-28  9:20     ` Guoqing Jiang
2021-05-25  9:46 ` [PATCH V3 3/8] md/raid5: move checking badblock before clone bio in raid5_read_one_chunk Guoqing Jiang
2021-05-25  9:46 ` [PATCH V3 4/8] md/raid5: avoid redundant bio clone " Guoqing Jiang
2021-05-25  9:46 ` [PATCH V3 5/8] md/raid1: rename print_msg with r1bio_existed Guoqing Jiang
2021-05-25  9:46 ` [PATCH V3 6/8] md/raid1: enable io accounting Guoqing Jiang
2021-05-25  9:46 ` [PATCH V3 7/8] md/raid10: " Guoqing Jiang
2021-05-25  9:46 ` [PATCH V3 8/8] md: mark some personalities as deprecated Guoqing Jiang
2021-06-01  1:19 ` [Update PATCH V3 2/8] md: add io accounting for raid0 and raid5 Guoqing Jiang
2021-06-03  1:17   ` Guoqing Jiang
2021-06-03  6:54     ` Song Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fb81639-2f1b-9acd-4d81-37d9817fd89b@gmail.com \
    --to=jgq516@gmail.com \
    --cc=artur.paszkiewicz@intel.com \
    --cc=hch@infradead.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox