From: Jens Axboe <axboe@kernel.dk>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, Shaohua Li <shli@kernel.org>
Subject: Re: [PATCH 0/4] Plugging changes for blk/md/umem
Date: Tue, 31 Jul 2012 09:33:35 +0200 [thread overview]
Message-ID: <50178A4F.8010806@kernel.dk> (raw)
In-Reply-To: <20120731172539.4feea95e@notabene.brown>
On 07/31/2012 09:25 AM, NeilBrown wrote:
> On Tue, 31 Jul 2012 09:08:55 +0200 Jens Axboe <axboe@kernel.dk> wrote:
>
>> On 07/26/2012 04:58 AM, NeilBrown wrote:
>>> Hi Jens,
>>> the following series makes a number of changes to plugging, moving
>>> common code from md and umem into block, and modifying it to allow
>>> md to get more value out of it.
>>> They've been sitting in -next for a while.
>>> Are you OK with me forwarding them to Linus, or would you rather they
>>> went though your tree?
>>
>> Thanks Neil, looks good. I will apply them to my tree and do some basic
>> testing, too, then push it off for this round (where I haven't pushed
>> out yet).
>>
>
> Thanks Jens,
> However I've just today discovered that the very first patch causes a real
> regression in throughput for RAID5 and while I'm sure I can fix it with a
> subsequent patch (once I figure out exactly what it happening) it might make
> sense to hold them all back for 3.7.
>
> However if you would like to take them now and fix up later (it is only a
> performance regression so it won't really affect bisection) I can work with
> that.
If you're confident we can fix it in this cycle (sounds like it, if you
have a grasp on the situation), then I don't think that should stop us.
--
Jens Axboe
next prev parent reply other threads:[~2012-07-31 7:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 2:58 [PATCH 0/4] Plugging changes for blk/md/umem NeilBrown
2012-07-26 2:58 ` [PATCH 2/4] blk: centralize non-request unplug handling NeilBrown
2012-07-26 2:58 ` [PATCH 4/4] blk: pass from_schedule to non-request unplug functions NeilBrown
2012-07-26 2:58 ` [PATCH 3/4] block: stack unplug NeilBrown
2012-07-26 2:58 ` [PATCH 1/4] md: remove plug_cnt feature of plugging NeilBrown
2012-07-31 7:08 ` [PATCH 0/4] Plugging changes for blk/md/umem Jens Axboe
2012-07-31 7:25 ` NeilBrown
2012-07-31 7:33 ` Jens Axboe [this message]
2012-07-31 8:44 ` NeilBrown
2012-07-31 8:54 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50178A4F.8010806@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).