From: Milan Broz <mbroz@redhat.com>
To: Behan Webster <behanw@converseincode.com>
Cc: agk@redhat.com, dm-devel@redhat.com, linux-raid@vger.kernel.org,
"Jan-Simon Möller" <dl9pf@gmx.de>,
pageexec@freemail.hu
Subject: Re: [PATCH] Remove VLAIS usage from dm-crypt
Date: Sat, 03 Nov 2012 20:30:08 +0100 [thread overview]
Message-ID: <509570C0.30208@redhat.com> (raw)
In-Reply-To: <1351620956-17583-2-git-send-email-behanw@converseincode.com>
On 10/30/2012 07:15 PM, Behan Webster wrote:
> From: Jan-Simon Möller <dl9pf@gmx.de>
>
> The use of variable length arrays in structs (VLAIS) in the Linux Kernel code
> precludes the use of compilers which don't implement VLAIS (for instance the
> Clang compiler). This patch instead allocates the appropriate amount of memory
> using an char array.
The dmcrypt code should use the same code practices as crypto API.
Apparently, your approach was not accepted there
http://article.gmane.org/gmane.linux.kernel/1386451
http://article.gmane.org/gmane.linux.kernel.cryptoapi/7993
> + char sdesc[sizeof(struct shash_desc)
> + + crypto_shash_descsize(lmk->hash_tfm)
> + + CRYPTO_MINALIGN] CRYPTO_MINALIGN_ATTR;
> + struct shash_desc *desc = (struct shash_desc *)sdesc;
I would like to see kenrel compilable by Clang but obfuscating the code
this way is perhaps not the ideal way.
Until it is accepted in crypto layer, NACK.
Milan
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-11-03 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 18:15 [PATCH] Removing the use of VLAIS from the Linux Kernel Behan Webster
2012-10-30 18:15 ` [PATCH] Remove VLAIS usage from dm-crypt Behan Webster
2012-11-03 19:30 ` Milan Broz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509570C0.30208@redhat.com \
--to=mbroz@redhat.com \
--cc=agk@redhat.com \
--cc=behanw@converseincode.com \
--cc=dl9pf@gmx.de \
--cc=dm-devel@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=pageexec@freemail.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).