linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Thomas Bächler" <thomas@archlinux.org>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: NeilBrown <neilb@suse.de>, linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/2] Modernize udev rules
Date: Mon, 11 Feb 2013 11:11:12 +0100	[thread overview]
Message-ID: <5118C3C0.2030708@archlinux.org> (raw)
In-Reply-To: <5118ACE1.5020503@msgid.tls.msk.ru>

[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]

Am 11.02.2013 09:33, schrieb Michael Tokarev:
> 11.02.2013 04:20, NeilBrown wrote:
>> On Sat,  9 Feb 2013 18:48:38 +0100 Thomas Bächler
>> <thomas@archlinux.org> wrote:
> 
>>> -IMPORT{program}="/sbin/blkid -o udev -p $tempnode"
>>> +IMPORT{builtin}="blkid"
> 
> Does this has additional udev version constrain?
> I mean, which is the minimum udev version to support this properly,
> do we care?

Udev relies on devtmpfs and thus does not create devices since version
176, therefore $tempnode is deprecated and only $devnode should be used
($tempnode seems to be around for compatibility, no idea if/when it will
be dropped).

The blkid builtin is also available since udev 176. In latest
util-linux, the 'blkid -o udev' output is marked as deprecated, although
Karel says it's not entirely going away for now.

Why do we care? We want correct udev rules ($tempnode vs. $devnode), and
the using builtin is faster and less error-prone than calling an
external tool (plus, it is used everywhere else in udev).

As for compatibility: I see no reason why anyone would use a version of
udev that is more than one year old (175) together with a mdadm version
that is to be released in the future (3.2.7). If someone really wants
that, they should be competent enough to adjust the udev rules for their
local build.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

  reply	other threads:[~2013-02-11 10:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-09 17:48 [PATCH 1/2] Modernize udev rules Thomas Bächler
2013-02-09 17:48 ` [PATCH 2/2] udev: Fix order of execution of the md rules Thomas Bächler
2013-02-09 20:49   ` [PATCHv2 " Thomas Bächler
2013-02-11  0:31     ` NeilBrown
2013-02-11 10:01       ` Thomas Bächler
2013-02-11  0:20 ` [PATCH 1/2] Modernize udev rules NeilBrown
2013-02-11  8:33   ` Michael Tokarev
2013-02-11 10:11     ` Thomas Bächler [this message]
2013-02-11 10:16       ` Michael Tokarev
2013-02-11 10:19         ` Thomas Bächler
2013-02-11 10:44       ` Dmitrijs Ledkovs
2013-02-11 10:48         ` Thomas Bächler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5118C3C0.2030708@archlinux.org \
    --to=thomas@archlinux.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=mjt@tls.msk.ru \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).