From: Martin Wilck <mwilck@arcor.de>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Subject: Re: mdadm -Db switches array to write-pending?!
Date: Wed, 17 Jul 2013 22:19:25 +0200 [thread overview]
Message-ID: <51E6FC4D.6080309@arcor.de> (raw)
In-Reply-To: <20130715151809.5fea8c78@notabene.brown>
On 07/15/2013 07:18 AM, NeilBrown wrote:
> Probably the best thing to do is:
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index d059af5..b19a1c8 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -5629,10 +5629,7 @@ static int get_bitmap_file(struct mddev * mddev, void __user * arg)
> char *ptr, *buf = NULL;
> int err = -ENOMEM;
>
> - if (md_allow_write(mddev))
> - file = kmalloc(sizeof(*file), GFP_NOIO);
> - else
> - file = kmalloc(sizeof(*file), GFP_KERNEL);
> + file = kmalloc(sizeof(*file), GFP_NOIO);
>
> if (!file)
> goto out;
>
>
> A failure here is not likely and not catastrophic.
>
> Does it fix the situation for you?
Yes it does.
Martin
next prev parent reply other threads:[~2013-07-17 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 17:54 mdadm -Db switches array to write-pending?! Martin Wilck
2013-07-15 5:18 ` NeilBrown
2013-07-17 20:19 ` Martin Wilck [this message]
2013-07-26 18:01 ` Martin Wilck
2013-07-26 21:58 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E6FC4D.6080309@arcor.de \
--to=mwilck@arcor.de \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).