* [PATCH RFC 11/13] md/bitmap: simplify the printing with '%pD' specifier [not found] <20210715031533.9553-1-justin.he@arm.com> @ 2021-07-15 3:15 ` Jia He 2021-07-16 9:38 ` Guoqing Jiang 0 siblings, 1 reply; 3+ messages in thread From: Jia He @ 2021-07-15 3:15 UTC (permalink / raw) To: linux-kernel Cc: Linus Torvalds, Christoph Hellwig, nd, Jia He, Song Liu, linux-raid After the behavior of '%pD' is changed to print the full path of file, the log printing can be simplified. Given the space with proper length would be allocated in vprintk_store(), it is worthy of dropping kmalloc()/kfree() to avoid additional space allocation. The error case is well handled in d_path_unsafe(), the error string would be copied in '%pD' buffer, no need to additionally handle IS_ERR(). Cc: Song Liu <song@kernel.org> Cc: linux-raid@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Jia He <justin.he@arm.com> --- drivers/md/md-bitmap.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c index e29c6298ef5c..a82f1c2ef83c 100644 --- a/drivers/md/md-bitmap.c +++ b/drivers/md/md-bitmap.c @@ -862,21 +862,12 @@ static void md_bitmap_file_unmap(struct bitmap_storage *store) */ static void md_bitmap_file_kick(struct bitmap *bitmap) { - char *path, *ptr = NULL; - if (!test_and_set_bit(BITMAP_STALE, &bitmap->flags)) { md_bitmap_update_sb(bitmap); if (bitmap->storage.file) { - path = kmalloc(PAGE_SIZE, GFP_KERNEL); - if (path) - ptr = file_path(bitmap->storage.file, - path, PAGE_SIZE); - - pr_warn("%s: kicking failed bitmap file %s from array!\n", - bmname(bitmap), IS_ERR(ptr) ? "" : ptr); - - kfree(path); + pr_warn("%s: kicking failed bitmap file %pD from array!\n", + bmname(bitmap), bitmap->storage.file); } else pr_warn("%s: disabling internal bitmap due to errors\n", bmname(bitmap)); -- 2.17.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RFC 11/13] md/bitmap: simplify the printing with '%pD' specifier 2021-07-15 3:15 ` [PATCH RFC 11/13] md/bitmap: simplify the printing with '%pD' specifier Jia He @ 2021-07-16 9:38 ` Guoqing Jiang 2021-07-23 17:05 ` Song Liu 0 siblings, 1 reply; 3+ messages in thread From: Guoqing Jiang @ 2021-07-16 9:38 UTC (permalink / raw) To: Jia He, linux-kernel Cc: Linus Torvalds, Christoph Hellwig, nd, Song Liu, linux-raid On 7/15/21 11:15 AM, Jia He wrote: > After the behavior of '%pD' is changed to print the full path of file, > the log printing can be simplified. > > Given the space with proper length would be allocated in vprintk_store(), > it is worthy of dropping kmalloc()/kfree() to avoid additional space > allocation. The error case is well handled in d_path_unsafe(), the error > string would be copied in '%pD' buffer, no need to additionally handle > IS_ERR(). > > Cc: Song Liu <song@kernel.org> > Cc: linux-raid@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Jia He <justin.he@arm.com> > --- > drivers/md/md-bitmap.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c > index e29c6298ef5c..a82f1c2ef83c 100644 > --- a/drivers/md/md-bitmap.c > +++ b/drivers/md/md-bitmap.c > @@ -862,21 +862,12 @@ static void md_bitmap_file_unmap(struct bitmap_storage *store) > */ > static void md_bitmap_file_kick(struct bitmap *bitmap) > { > - char *path, *ptr = NULL; > - > if (!test_and_set_bit(BITMAP_STALE, &bitmap->flags)) { > md_bitmap_update_sb(bitmap); > > if (bitmap->storage.file) { > - path = kmalloc(PAGE_SIZE, GFP_KERNEL); > - if (path) > - ptr = file_path(bitmap->storage.file, > - path, PAGE_SIZE); > - > - pr_warn("%s: kicking failed bitmap file %s from array!\n", > - bmname(bitmap), IS_ERR(ptr) ? "" : ptr); > - > - kfree(path); > + pr_warn("%s: kicking failed bitmap file %pD from array!\n", > + bmname(bitmap), bitmap->storage.file); > } else > pr_warn("%s: disabling internal bitmap due to errors\n", > bmname(bitmap)); Looks good, Acked-by: Guoqing Jiang <guoqing.jiang@linux.dev> Thanks, Guoqing ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RFC 11/13] md/bitmap: simplify the printing with '%pD' specifier 2021-07-16 9:38 ` Guoqing Jiang @ 2021-07-23 17:05 ` Song Liu 0 siblings, 0 replies; 3+ messages in thread From: Song Liu @ 2021-07-23 17:05 UTC (permalink / raw) To: Guoqing Jiang Cc: Jia He, open list, Linus Torvalds, Christoph Hellwig, nd, linux-raid On Fri, Jul 16, 2021 at 2:41 AM Guoqing Jiang <guoqing.jiang@linux.dev> wrote: > > > > On 7/15/21 11:15 AM, Jia He wrote: > > After the behavior of '%pD' is changed to print the full path of file, > > the log printing can be simplified. > > > > Given the space with proper length would be allocated in vprintk_store(), > > it is worthy of dropping kmalloc()/kfree() to avoid additional space > > allocation. The error case is well handled in d_path_unsafe(), the error > > string would be copied in '%pD' buffer, no need to additionally handle > > IS_ERR(). > > > > Cc: Song Liu <song@kernel.org> > > Cc: linux-raid@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Jia He <justin.he@arm.com> > > --- > > drivers/md/md-bitmap.c | 13 ++----------- > > 1 file changed, 2 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/md/md-bitmap.c b/drivers/md/md-bitmap.c > > index e29c6298ef5c..a82f1c2ef83c 100644 > > --- a/drivers/md/md-bitmap.c > > +++ b/drivers/md/md-bitmap.c > > @@ -862,21 +862,12 @@ static void md_bitmap_file_unmap(struct bitmap_storage *store) > > */ > > static void md_bitmap_file_kick(struct bitmap *bitmap) > > { > > - char *path, *ptr = NULL; > > - > > if (!test_and_set_bit(BITMAP_STALE, &bitmap->flags)) { > > md_bitmap_update_sb(bitmap); > > > > if (bitmap->storage.file) { > > - path = kmalloc(PAGE_SIZE, GFP_KERNEL); > > - if (path) > > - ptr = file_path(bitmap->storage.file, > > - path, PAGE_SIZE); > > - > > - pr_warn("%s: kicking failed bitmap file %s from array!\n", > > - bmname(bitmap), IS_ERR(ptr) ? "" : ptr); > > - > > - kfree(path); > > + pr_warn("%s: kicking failed bitmap file %pD from array!\n", > > + bmname(bitmap), bitmap->storage.file); This is neat! Acked-by: Song Liu <song@kernel.org> > > } else > > pr_warn("%s: disabling internal bitmap due to errors\n", > > bmname(bitmap)); > > Looks good, Acked-by: Guoqing Jiang <guoqing.jiang@linux.dev> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-23 17:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210715031533.9553-1-justin.he@arm.com>
2021-07-15 3:15 ` [PATCH RFC 11/13] md/bitmap: simplify the printing with '%pD' specifier Jia He
2021-07-16 9:38 ` Guoqing Jiang
2021-07-23 17:05 ` Song Liu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox