linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@arcor.de>
To: NeilBrown <neilb@suse.de>, linux-raid@vger.kernel.org
Subject: DDF: regression caused by 273989b9 / ce45c819
Date: Tue, 06 Aug 2013 20:14:35 +0200	[thread overview]
Message-ID: <52013D0B.8060404@arcor.de> (raw)

Hi Neil,

these patches break the unit test 10ddf-geometry. I saw the regression
with both patches applied. The problem occurs when subarrays are
deleted. With these patches in place, sync_metadata() will not overwrite
deleted conf records on disk, but lseek() over them instead. When the
meta data is read back, this will cause errors.

I would like to ask you to play safe here and revert these patches. It
might be possible to fix the --kill-subarray problem, but there are
other possible scenarios where the number of valid conf records on a
disk decreases - I don't think we have a reliable way to check whether
it is safe to skip over empty entries. We must also be prepared for
other DDF implementations to read our meta data, so we must refrain from
putting any writing anything that might be confusing.

Regards
Martin

             reply	other threads:[~2013-08-06 18:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-06 18:14 Martin Wilck [this message]
2013-08-07  7:09 ` DDF: regression caused by 273989b9 / ce45c819 NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52013D0B.8060404@arcor.de \
    --to=mwilck@arcor.de \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).