linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: md: include "linux/vmalloc.h" in "dm-cache-policy-hints.c"
@ 2013-10-30  6:17 Chen Gang
  2013-10-30 14:38 ` Mike Snitzer
  0 siblings, 1 reply; 3+ messages in thread
From: Chen Gang @ 2013-10-30  6:17 UTC (permalink / raw)
  To: agk, snitzer, neilb; +Cc: dm-devel, linux-raid

Need include related header file, or can not pass compiling, the
related error (for powerpc with allmodconfig):

    CC [M]  drivers/md/dm-cache-policy-hints.o
  drivers/md/dm-cache-policy-hints.c: In function ‘alloc_hash’:
  drivers/md/dm-cache-policy-hints.c:94:2: error: implicit declaration of function ‘vzalloc’ [-Werror=implicit-function-declaration]
  drivers/md/dm-cache-policy-hints.c:94:14: warning: assignment makes pointer from integer without a cast [enabled by default]
  drivers/md/dm-cache-policy-hints.c: In function ‘free_hash’:
  drivers/md/dm-cache-policy-hints.c:101:2: error: implicit declaration of function ‘vfree’ [-Werror=implicit-function-declaration]
  drivers/md/dm-cache-policy-hints.c: In function ‘alloc_bitset’:
  drivers/md/dm-cache-policy-hints.c:184:2: warning: return makes pointer from integer without a cast [enabled by default]


Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
 drivers/md/dm-cache-policy-hints.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/md/dm-cache-policy-hints.c b/drivers/md/dm-cache-policy-hints.c
index 312cfb7..a8c1930 100644
--- a/drivers/md/dm-cache-policy-hints.c
+++ b/drivers/md/dm-cache-policy-hints.c
@@ -15,6 +15,7 @@
 #include <linux/hash.h>
 #include <linux/list.h>
 #include <linux/module.h>
+#include <linux/vmalloc.h>
 
 #define DM_MSG_PREFIX "cache-policy-hints"
 
-- 
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: drivers: md: include "linux/vmalloc.h" in "dm-cache-policy-hints.c"
  2013-10-30  6:17 [PATCH] drivers: md: include "linux/vmalloc.h" in "dm-cache-policy-hints.c" Chen Gang
@ 2013-10-30 14:38 ` Mike Snitzer
  2013-10-31  0:48   ` Chen Gang
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Snitzer @ 2013-10-30 14:38 UTC (permalink / raw)
  To: Chen Gang; +Cc: agk, neilb, linux-raid, dm-devel

On Wed, Oct 30 2013 at  2:17am -0400,
Chen Gang <gang.chen@asianux.com> wrote:

> Need include related header file, or can not pass compiling, the
> related error (for powerpc with allmodconfig):
> 
>     CC [M]  drivers/md/dm-cache-policy-hints.o
>   drivers/md/dm-cache-policy-hints.c: In function ‘alloc_hash’:
>   drivers/md/dm-cache-policy-hints.c:94:2: error: implicit declaration of function ‘vzalloc’ [-Werror=implicit-function-declaration]
>   drivers/md/dm-cache-policy-hints.c:94:14: warning: assignment makes pointer from integer without a cast [enabled by default]
>   drivers/md/dm-cache-policy-hints.c: In function ‘free_hash’:
>   drivers/md/dm-cache-policy-hints.c:101:2: error: implicit declaration of function ‘vfree’ [-Werror=implicit-function-declaration]
>   drivers/md/dm-cache-policy-hints.c: In function ‘alloc_bitset’:
>   drivers/md/dm-cache-policy-hints.c:184:2: warning: return makes pointer from integer without a cast [enabled by default]
> 
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>

This was already fixed a couple days ago in the linux-dm.git 'for-next'
branch.

But thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: drivers: md: include "linux/vmalloc.h" in "dm-cache-policy-hints.c"
  2013-10-30 14:38 ` Mike Snitzer
@ 2013-10-31  0:48   ` Chen Gang
  0 siblings, 0 replies; 3+ messages in thread
From: Chen Gang @ 2013-10-31  0:48 UTC (permalink / raw)
  To: Mike Snitzer; +Cc: agk, neilb, linux-raid, dm-devel

On 10/30/2013 10:38 PM, Mike Snitzer wrote:
> On Wed, Oct 30 2013 at  2:17am -0400,
> Chen Gang <gang.chen@asianux.com> wrote:
> 
>> Need include related header file, or can not pass compiling, the
>> related error (for powerpc with allmodconfig):
>>
>>     CC [M]  drivers/md/dm-cache-policy-hints.o
>>   drivers/md/dm-cache-policy-hints.c: In function ‘alloc_hash’:
>>   drivers/md/dm-cache-policy-hints.c:94:2: error: implicit declaration of function ‘vzalloc’ [-Werror=implicit-function-declaration]
>>   drivers/md/dm-cache-policy-hints.c:94:14: warning: assignment makes pointer from integer without a cast [enabled by default]
>>   drivers/md/dm-cache-policy-hints.c: In function ‘free_hash’:
>>   drivers/md/dm-cache-policy-hints.c:101:2: error: implicit declaration of function ‘vfree’ [-Werror=implicit-function-declaration]
>>   drivers/md/dm-cache-policy-hints.c: In function ‘alloc_bitset’:
>>   drivers/md/dm-cache-policy-hints.c:184:2: warning: return makes pointer from integer without a cast [enabled by default]
>>
>>
>> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> 
> This was already fixed a couple days ago in the linux-dm.git 'for-next'
> branch.
> 
> But thanks.
> 
> 

Thank you too.
-- 
Chen Gang
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-10-31  0:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-30  6:17 [PATCH] drivers: md: include "linux/vmalloc.h" in "dm-cache-policy-hints.c" Chen Gang
2013-10-30 14:38 ` Mike Snitzer
2013-10-31  0:48   ` Chen Gang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).