From: Brad Campbell <lists2009@fnarfbargle.com>
To: NeilBrown <neilb@suse.de>
Cc: Mikael Abrahamsson <swmike@swm.pp.se>, linux-raid@vger.kernel.org
Subject: Re: feature re-quest for "re-write"
Date: Tue, 25 Feb 2014 10:26:05 +0800 [thread overview]
Message-ID: <530BFF3D.8000400@fnarfbargle.com> (raw)
In-Reply-To: <20140225131017.6e71fa5a@notabene.brown>
On 25/02/14 10:10, NeilBrown wrote:
> This code is obviously too subtle.
Not at all, it's my understanding that is under-developed. I was just
looking for something obvious to explain the behaviour others have been
reporting where a check won't trigger a re-write of a pending sector if
the sector is a p or q rather than data.
> If 0 drives have failed, then 's->failed' is 0 (it is the count of failed
> drives), and 's->q_failed' is also 0 (it is a boolean flag, and q clearly
> hasn't failed as nothing has).
> So the first 'if' branch will be followed (as "0 == 0") and check_state set to
> check_state_run.
> Then as q_failed is still 0 and failed < 2, check_state gets set to
> check_state_run_pq.
>
Got it, thanks for taking the time to set me straight.
Regards,
Brad
prev parent reply other threads:[~2014-02-25 2:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 18:09 feature re-quest for "re-write" Mikael Abrahamsson
2014-02-24 1:30 ` Brad Campbell
2014-02-24 1:46 ` Eyal Lebedinsky
2014-02-24 2:11 ` Brad Campbell
2014-02-24 3:40 ` Eyal Lebedinsky
2014-02-24 14:14 ` Wilson Jonathan
2014-02-24 20:39 ` Eyal Lebedinsky
2014-02-25 3:16 ` NeilBrown
2014-02-25 5:58 ` Eyal Lebedinsky
2014-02-25 7:05 ` Stan Hoeppner
2014-02-25 7:45 ` Eyal Lebedinsky
2014-02-25 7:58 ` Eyal Lebedinsky
2014-02-25 8:35 ` NeilBrown
2014-02-25 11:08 ` Eyal Lebedinsky
2014-02-25 11:28 ` Mikael Abrahamsson
2014-02-25 12:05 ` Eyal Lebedinsky
2014-02-25 12:17 ` Mikael Abrahamsson
2014-02-25 12:32 ` Eyal Lebedinsky
2014-02-24 2:42 ` Mikael Abrahamsson
2014-02-24 2:24 ` Brad Campbell
2014-02-25 2:10 ` NeilBrown
2014-02-25 2:26 ` Brad Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530BFF3D.8000400@fnarfbargle.com \
--to=lists2009@fnarfbargle.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=swmike@swm.pp.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).