From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nate Dailey Subject: Re: [dm-devel] [PATCH] dm-raid: check events in super_validate Date: Wed, 26 Feb 2014 19:17:28 -0500 Message-ID: <530E8418.50707@stratus.com> References: <52ED0628.4030203@stratus.com> <20140225163020.6f299f15@notabene.brown> <530D17BF.7090008@stratus.com> <3E58643B-64BF-4A4B-9D44-3D075148FE80@redhat.com> <4A643D2E-04C2-462A-8CF8-9BB2A4DC38AE@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4A643D2E-04C2-462A-8CF8-9BB2A4DC38AE@redhat.com> Sender: linux-raid-owner@vger.kernel.org To: Brassow Jonathan , device-mapper development Cc: linux-raid@vger.kernel.org List-Id: linux-raid.ids Interesting. I had tried this with the latest stable kernel.org kernel (as of a month or so ago) and still hit it. I'll mention that the initial resync on creating the raid1 can be interrupted okay; the problem only happens after that completes, and a disk is removed and re-added. Nate On 02/26/2014 05:21 PM, Brassow Jonathan wrote: > On Feb 25, 2014, at 4:59 PM, Brassow Jonathan wrote: > >> On Feb 25, 2014, at 4:22 PM, Nate Dailey wrote: >> >>> Here's what I've done to reproduce this: >>> >>> - remove a disk containing one leg of an LVM raid1 mirror >>> - do enough IO that a lengthy recovery will be required >>> - insert the removed disk >>> - let recovery begin, but deactivate the LV before it completes >>> - activate the LV >>> >>> This is the point where the recovery should start back up, but it doesn't. I haven't tried this in a few weeks, but am happy to try it again if it would help. >> Confirmed (test output below). I'll get started on this. This code can be a bit tricky and I've been away from it for a while. It will take me a bit to re-familiarize myself with it and review your patch. > I've tested this again with the latest code from upstream (kernel 3.14.0-rc4) and I cannot reproduce the problem there. I'll see if I can find the last non-working version... > > brassow >