From: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH] Fix race between --create and --incremental
Date: Fri, 11 Apr 2014 12:08:45 +0200 [thread overview]
Message-ID: <5347BF2D.1030609@intel.com> (raw)
In-Reply-To: <20140410103337.30c9dc7c@notabene.brown>
On 04/10/2014 02:33 AM, NeilBrown wrote:
> On Wed, 9 Apr 2014 17:14:59 +0200 Artur Paszkiewicz
> <artur.paszkiewicz@intel.com> wrote:
>
>> This modifies locking in Create to eliminate a situation where
>> --incremental can assemble a device between write_init_super() and
>> add_disk(), which causes Create to fail.
>>
>> It sporadically occurs e.g. when metadata is written on a device,
>> causing an udev change event which triggers mdadm --incremental.
>>
>> Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
>
> Thanks for the patch.
> I've taken the liberty of changing it a little. I didn't like the fact that
> we dropped the lock and then took it again. It probably doesn't matter, but
> it feels cleaner to hold it the whole time.
>
> So this is the result. Let me know if you disagree at all.
Hello Neil,
Your changes are OK, thanks.
Regards,
Artur
next prev parent reply other threads:[~2014-04-11 10:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 15:14 [PATCH] Fix race between --create and --incremental Artur Paszkiewicz
2014-04-10 0:33 ` NeilBrown
2014-04-11 10:08 ` Artur Paszkiewicz [this message]
2014-04-30 11:50 ` Artur Paszkiewicz
2014-05-01 7:17 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5347BF2D.1030609@intel.com \
--to=artur.paszkiewicz@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).