From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98CBBEB64DB for ; Thu, 15 Jun 2023 08:37:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244764AbjFOIhb (ORCPT ); Thu, 15 Jun 2023 04:37:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244961AbjFOIhM (ORCPT ); Thu, 15 Jun 2023 04:37:12 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 702D6294E; Thu, 15 Jun 2023 01:37:11 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 25F851F750; Thu, 15 Jun 2023 08:37:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1686818230; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m654n0RNYefLIPOTGUOJVVh2YqbTJGcXD1WMJ/IaZL0=; b=B0TTAgUaALMpQ/IswBElHEBYiRzpWHUb8ZmuDHLCN1YKW4OK6m95TVLbMSDRG7JMPszP6V Ad3KxDHWNbCZZMGJw55Gj2eNBIPopYmmIKL3emDQL2I4YfuodlB13pViKAJQtcxl+UC/wq G2Czpe/diNbQnNjwTKTo7hcJ4K/SiH8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1686818230; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=m654n0RNYefLIPOTGUOJVVh2YqbTJGcXD1WMJ/IaZL0=; b=kwB+V0KT3WVqmZ/z08b+E7JJpNoMPU4blW02yDcshubyUS8ZpUxnaWbOHjbnc172VIqD/9 gq63PopbJQ9PvSCg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 157D413467; Thu, 15 Jun 2023 08:37:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DKLcBLbNimSQNgAAMHmgww (envelope-from ); Thu, 15 Jun 2023 08:37:10 +0000 Message-ID: <53ed6ade-371b-8a9c-112e-a07c251d42e7@suse.de> Date: Thu, 15 Jun 2023 10:37:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 09/11] md-bitmap: don't use ->index for pages backing the bitmap file Content-Language: en-US To: Christoph Hellwig , Song Liu Cc: linux-raid@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20230615064840.629492-1-hch@lst.de> <20230615064840.629492-10-hch@lst.de> From: Hannes Reinecke In-Reply-To: <20230615064840.629492-10-hch@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-raid@vger.kernel.org On 6/15/23 08:48, Christoph Hellwig wrote: > The md driver allocates pages for storing the bitmap file data, which > are not page cache pages, and then stores the page granularity file > offset in page->index, which is a field that isn't really valid except > for page cache pages. > Hmm. Willy told me that ->index is free to use if you're not dealing with page cache pages (brd does the same thing). Cheers, Hannes