* mdadm patch Monitor.c
@ 2014-09-02 18:12 Phil Kauffman
0 siblings, 0 replies; only message in thread
From: Phil Kauffman @ 2014-09-02 18:12 UTC (permalink / raw)
To: neilb; +Cc: linux-raid
[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]
Neil,
Hopefully, you are still the maintainer of mdadm.
I would like to request the following trivial patch... pretty please!
--- Monitor.c 2014-08-21 05:16:56.000000000 -0500
+++ Monitor.c.new 2014-09-02 13:03:45.106590425 -0500
@@ -402,14 +402,12 @@
if (disc && disc[0] == ' ')
fprintf(mp, "Extra information:%s.\n\n", disc);
- fprintf(mp, "Faithfully yours, etc.\n");
-
mdstat = fopen("/proc/mdstat", "r");
if (mdstat) {
char buf[8192];
int n;
fprintf(mp,
- "\nP.S. The /proc/mdstat file"
+ "\nThe /proc/mdstat file"
" currently contains the following:\n\n");
while ( (n=fread(buf, 1, sizeof(buf), mdstat)) > 0)
n=fwrite(buf, 1, n, mp);
The words removed above are superfluous and add no value to the message.
In addition, they imply that the message is from a person, which is
obviously not the case.
Cheers,
Phil
--
Phil Kauffman
Systems Admin
Dept. of Computer Science
University of Chicago
kauffman@cs.uchicago.edu
773-702-3913
[-- Attachment #2: Monitor.c.patch --]
[-- Type: text/x-patch, Size: 575 bytes --]
--- Monitor.c 2014-08-21 05:16:56.000000000 -0500
+++ Monitor.c.new 2014-09-02 13:03:45.106590425 -0500
@@ -402,14 +402,12 @@
if (disc && disc[0] == ' ')
fprintf(mp, "Extra information:%s.\n\n", disc);
- fprintf(mp, "Faithfully yours, etc.\n");
-
mdstat = fopen("/proc/mdstat", "r");
if (mdstat) {
char buf[8192];
int n;
fprintf(mp,
- "\nP.S. The /proc/mdstat file"
+ "\nThe /proc/mdstat file"
" currently contains the following:\n\n");
while ( (n=fread(buf, 1, sizeof(buf), mdstat)) > 0)
n=fwrite(buf, 1, n, mp);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-09-02 18:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-02 18:12 mdadm patch Monitor.c Phil Kauffman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).