From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Kent Overstreet <kmo@daterainc.com>, Neil Brown <neilb@suse.de>,
linux-bcache@vger.kernel.org
Cc: linux-raid@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH 1/1] bcache: Deletion of an unnecessary check before the function call "kobject_put"
Date: Wed, 19 Nov 2014 21:34:20 +0100 [thread overview]
Message-ID: <546CFECC.8020309@users.sourceforge.net> (raw)
In-Reply-To: <5317A59D.4@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 19 Nov 2014 21:25:39 +0100
The kobject_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/md/bcache/super.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index d4713d0..1443c55 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -2076,8 +2076,7 @@ static void bcache_exit(void)
{
bch_debug_exit();
bch_request_exit();
- if (bcache_kobj)
- kobject_put(bcache_kobj);
+ kobject_put(bcache_kobj);
if (bcache_wq)
destroy_workqueue(bcache_wq);
if (bcache_major)
--
2.1.3
next parent reply other threads:[~2014-11-19 20:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5307CAA2.8060406@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402212321410.2043@localhost6.localdomain6>
[not found] ` <530A086E.8010901@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402231635510.1985@localhost6.localdomain6>
[not found] ` <530A72AA.3000601@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402240658210.2090@localhost6.localdomain6>
[not found] ` <530B5FB6.6010207@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402241710370.2074@hadrien>
[not found] ` <530C5E18.1020800@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251014170.2080@hadrien>
[not found] ` <530CD2C4.4050903@users.sourceforge.net>
[not found] ` <alpine.DEB.2.10.1402251840450.7035@hadrien>
[not found] ` <530CF8FF.8080600@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402252117150.2047@localhost6.localdomain6>
[not found] ` <530DD06F.4090703@users.sourceforge.net>
[not found] ` <alpine.DEB.2.02.1402262129250.2221@localhost6.localdomain6>
[not found] ` <5317A59D.4@users.so urceforge.net>
[not found] ` <5317A59D.4@users.sourceforge.net>
2014-11-19 20:34 ` SF Markus Elfring [this message]
2015-07-08 17:48 ` [PATCH] bcache: Deletion of an unnecessary check before the function call "kobject_put" SF Markus Elfring
2014-11-19 20:55 ` [PATCH 1/1] dm: Deletion of unnecessary checks before two function calls SF Markus Elfring
2015-02-02 15:11 ` [PATCH 0/3] md: Deletion of a few unnecessary checks SF Markus Elfring
2015-02-02 15:17 ` [PATCH 1/3] dm snapshot: Deletion of unnecessary checks before the function call "vfree" SF Markus Elfring
2015-02-02 15:20 ` [PATCH 2/3] md/bitmap: Delete an unnecessary check before the function call "kfree" SF Markus Elfring
2015-02-02 19:46 ` NeilBrown
2015-02-02 15:23 ` [PATCH 3/3] dm ioctl: Delete an unnecessary check before the function call "dm_table_destroy" SF Markus Elfring
2015-02-06 21:12 ` Mike Snitzer
2015-02-08 9:55 ` SF Markus Elfring
2015-02-08 14:02 ` Mike Snitzer
2015-02-08 15:52 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546CFECC.8020309@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kmo@daterainc.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).