From: nick <xerofoify@gmail.com>
To: agk@redhat.com, linux-raid@vger.kernel.org, dm-devel@redhat.com,
linux-kernel@vger.kernel.org, snitzer@redhat.com
Subject: Re: [PATCH RESEND] md:Remove no longer needed fix me comment in dm-region-hash.c for removing the structure pointer, *rh from the definiton of dm_region
Date: Tue, 20 Jan 2015 06:36:10 -0500 [thread overview]
Message-ID: <54BE3DAA.5080900@gmail.com> (raw)
In-Reply-To: <20150120111951.GB17599@agk-dp.fab.redhat.com>
Alasdair,
Unless we use a union or something similar there seems to be no easy
way without rewriting a lot of an already function driver file.
Cheers,
Nick
On 2015-01-20 06:19 AM, Alasdair G Kergon wrote:
> On Mon, Jan 19, 2015 at 10:16:21PM -0500, Nicholas Krause wrote:
>> Removes the no longer needed fix me comment questioning if we need to remove
>> the structure pointer,rh as defined as a structure of type dsm_region_hash
>> from the definition of the structure, dm_region. Furthermore this pointer is
>> needed in order for various functions to run and build successfully in the file,
>> dm-region-hash.c.
>
> You've misunderstood the comment!
> Is there a better alternative to having every dm_region struct store its own copy of
> this pointer?
>
> Alasdair
>
next prev parent reply other threads:[~2015-01-20 11:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 3:16 [PATCH RESEND] md:Remove no longer needed fix me comment in dm-region-hash.c for removing the structure pointer, *rh from the definiton of dm_region Nicholas Krause
2015-01-20 11:19 ` [dm-devel] " Alasdair G Kergon
2015-01-20 11:36 ` nick [this message]
2015-01-20 11:40 ` Alasdair G Kergon
2015-01-20 13:17 ` Nick Krause
2015-01-26 20:09 ` Nick Krause
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BE3DAA.5080900@gmail.com \
--to=xerofoify@gmail.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).