From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [PATCH 3/3] dm ioctl: Delete an unnecessary check before the function call "dm_table_destroy" Date: Sun, 08 Feb 2015 10:55:40 +0100 Message-ID: <54D7329C.206@users.sourceforge.net> References: <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54CF93BB.40206@users.sourceforge.net> <54CF9666.5060407@users.sourceforge.net> <20150206211234.GA14803@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150206211234.GA14803@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Mike Snitzer Cc: Alasdair Kergon , Neil Brown , dm-devel@redhat.com, linux-raid@vger.kernel.org, Julia Lawall , kernel-janitors@vger.kernel.org, LKML List-Id: linux-raid.ids > Your proposed patch (while technically correct) hurts code clarity. How many source code readability and understanding challenges does each additional condition check cause? Can the affected place become also a bit more efficient? Regards, Markus