From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: "heming.zhao@suse.com" <heming.zhao@suse.com>,
linux-raid@vger.kernel.org, song@kernel.org
Cc: xni@redhat.com
Subject: Re: [PATCH] md/bitmap: don't set sb values if can't pass sanity check
Date: Tue, 29 Mar 2022 15:00:07 +0800 [thread overview]
Message-ID: <54f68ed0-6674-3e8d-eea1-086b4c361411@linux.dev> (raw)
In-Reply-To: <b9c2bbef-9bfd-1b60-9e56-9daedc016b3a@suse.com>
On 3/29/22 10:37 AM, heming.zhao@suse.com wrote:
> Yes, legacy code already handle/print the reason before "goto out".
> For comment style, this area comment is legacy code, not my new added.
> But I could
> modify it to follow the code rule.
I am not blame you 😁. Since we are deal with relevant code, it would be
better to correct
it's style as well, and a dedicated patch to improve style is usually
not welcomed IMO.
Thanks,
Guoqing
next prev parent reply other threads:[~2022-03-29 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 2:52 [PATCH] md/bitmap: don't set sb values if can't pass sanity check Heming Zhao
2022-03-28 0:43 ` Guoqing Jiang
2022-03-29 2:37 ` heming.zhao
2022-03-29 7:00 ` Guoqing Jiang [this message]
2022-03-29 13:05 ` [kbuild] " Dan Carpenter
2022-03-30 2:18 ` heming.zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54f68ed0-6674-3e8d-eea1-086b4c361411@linux.dev \
--to=guoqing.jiang@linux.dev \
--cc=heming.zhao@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).