From: Guoqing Jiang <gqJiang@suse.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, rgoldwyn@suse.de
Subject: Re: [PATCH 11/11] Reuse the write_bitmap for update uuid
Date: Wed, 17 Jun 2015 09:53:56 +0800 [thread overview]
Message-ID: <5580D334.2030101@suse.com> (raw)
In-Reply-To: <20150617095407.14d4ed4e@home.neil.brown.name>
Hi Neil,
>> To handle different situations, it can support updating the uuid of
>> the bitmap. This patch also removes the redundant bitmap_update_uuid.
>>
>> Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
>>
>
> Hi,
> I have applied all patches except this one to a new branch called
> 'cluster' in git://neil.brown.name/mdadm/
> I'll merge it with the master branch after the next point release.
>
> I made a few changes on the way - mostly fixing indenting. One more
> significant change is that I made it compile if /usr/include/corosync
> doesn't exist.
>
Thanks a lot for that!
> I didn't apply this change because it doesn't make sense to me. The
> format of the bitmap is independent of the metadata used, so using a
> ->ss method to update t he bitmap doesn't make sense.
>
> If you can explain what problem you are trying to fix, I'm sure we can
> find a solution that we are both happy with.
>
>
There is no problem with previous code, this change just want to
reuse existed function, and it is ok to drop the patch.
Thanks,
Guoqing
next prev parent reply other threads:[~2015-06-17 1:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 5:42 [PATCH 00/11] mdadm tool: add the support for cluster-md Guoqing Jiang
2015-06-10 5:42 ` [PATCH 01/11] Create n bitmaps for clustered mode Guoqing Jiang
2015-06-10 5:42 ` [PATCH 02/11] Add nodes option while creating md Guoqing Jiang
2015-06-10 5:42 ` [PATCH 03/11] home-cluster while creating an array Guoqing Jiang
2015-06-10 5:42 ` [PATCH 04/11] Show all bitmaps while examining bitmap Guoqing Jiang
2015-06-10 5:42 ` [PATCH 05/11] Add a new clustered disk Guoqing Jiang
2015-06-10 5:42 ` [PATCH 06/11] Convert a bitmap=none device to clustered Guoqing Jiang
2015-06-10 5:42 ` [PATCH 07/11] Skip clustered devices in incremental Guoqing Jiang
2015-06-10 5:42 ` [PATCH 08/11] mdadm: add the ability to change cluster name Guoqing Jiang
2015-06-10 5:42 ` [PATCH 09/11] mdadm: change the num of cluster node Guoqing Jiang
2015-06-10 5:42 ` [PATCH 10/11] Reuse calc_bitmap_size to reduce code size Guoqing Jiang
2015-06-10 5:42 ` [PATCH 11/11] Reuse the write_bitmap for update uuid Guoqing Jiang
2015-06-16 23:54 ` Neil Brown
2015-06-17 1:53 ` Guoqing Jiang [this message]
2015-06-10 5:53 ` [PATCH 00/11] mdadm tool: add the support for cluster-md Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5580D334.2030101@suse.com \
--to=gqjiang@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).