From: Guoqing Jiang <gqJiang@suse.com>
To: Goldwyn Rodrigues <rgoldwyn@suse.com>
Cc: neilb@suse.com, linux-raid@vger.kernel.org
Subject: Re: [PATCH 2/2] Make cmap_* also has same policy as dlm_*
Date: Tue, 04 Aug 2015 18:09:19 +0800 [thread overview]
Message-ID: <55C08F4F.7070806@suse.com> (raw)
In-Reply-To: <55BF5766.9070008@suse.com>
Hi Goldwyn,
Goldwyn Rodrigues wrote:
> On 08/03/2015 06:31 AM, Guoqing Jiang wrote:
>> Let libcmap lib and related funs also only need one-time
>> setup during mdadm running period.
>>
>> Signed-off-by: Guoqing Jiang <gqjiang@suse.com>
>> ---
>> mdadm.c | 23 +++++++++++--------
>> mdadm.h | 20 ++++++++++++++++
>> util.c | 81
>> +++++++++++++++++++++++++++++++++++++++--------------------------
>> 3 files changed, 82 insertions(+), 42 deletions(-)
>>
[snip]
>> +
>> +void set_hookers(void)
>> +{
>> + set_dlm_hookers();
>> + set_cmap_hookers();
>> +}
>> +
>> +void free_hookers(void)
>> +{
>> + free_dlm_hookers();
>> + free_cmap_hookers();
>> +}
>>
>
> You could put both functions in a single structure called cluster_hooks.
>
Yes, it could be. If there more libs are needed in future, so I prefer
separate them according to different libraries.
Thanks,
Guoqing
next prev parent reply other threads:[~2015-08-04 10:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 11:31 [PATCH 1/2] Safeguard against writing to an active device of another node Guoqing Jiang
2015-08-03 11:31 ` [PATCH 2/2] Make cmap_* also has same policy as dlm_* Guoqing Jiang
2015-08-03 11:58 ` Goldwyn Rodrigues
2015-08-04 10:09 ` Guoqing Jiang [this message]
2015-08-03 11:56 ` [PATCH 1/2] Safeguard against writing to an active device of another node Goldwyn Rodrigues
2015-08-04 10:05 ` Guoqing Jiang
2015-08-04 10:18 ` Adam Goryachev
2015-08-04 10:23 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C08F4F.7070806@suse.com \
--to=gqjiang@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=rgoldwyn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).