From: Guoqing Jiang <gqjiang@suse.com>
To: NeilBrown <neilb@suse.com>
Cc: rgoldwyn@suse.com, linux-raid@vger.kernel.org
Subject: Re: [PATCH 2/3] md-cluster: introduce clear_clusterinfo_from_sb
Date: Fri, 27 Nov 2015 14:03:19 +0800 [thread overview]
Message-ID: <5657F227.3030202@suse.com> (raw)
In-Reply-To: <87y4dk577c.fsf@notabene.neil.brown.name>
Hi Neil,
On 11/27/2015 01:42 PM, NeilBrown wrote:
> On Fri, Nov 20 2015, Guoqing Jiang <gqjiang@suse.com> wrote:
>
>> To change the bitmap from clustered to none, we also
>> need to clean related info about cluster from sb, such
>> as version, nodes and cluster_name.
> I've applied the other two (though I removed the __func__ and __LINE__
> From error messages - they are just noise: the source of the message can
> easily be found with out them - I should remove all the others).
>
> However I haven't applied this because there doesn't seem to be any
> point.
> Once your told that main md superblock that there is no bitmap, it
> doesn't really matter what data is in the superblock of that
> non-existent bitmap - it will never be looked at. Will it?
mdadm could still get nodes and cluster_name after change
bitmap to none, so some cmds like "mdadm -X /dev/sda" could
still see clustered info, it seems a little confused for user.
Thanks,
Guoqing
next prev parent reply other threads:[~2015-11-27 6:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 8:35 [PATCH 1/3] md-cluster: append some actions when change bitmap from clustered to none Guoqing Jiang
2015-11-20 8:35 ` [PATCH 2/3] md-cluster: introduce clear_clusterinfo_from_sb Guoqing Jiang
2015-11-27 5:42 ` NeilBrown
2015-11-27 6:03 ` Guoqing Jiang [this message]
2015-11-30 1:08 ` NeilBrown
2015-11-30 1:45 ` Guoqing Jiang
2015-11-20 8:35 ` [PATCH 3/3] md-cluster: update the documentation Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5657F227.3030202@suse.com \
--to=gqjiang@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=rgoldwyn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).