From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guoqing Jiang Subject: Re: [PATCH 4/8] Grow: Grow_addbitmap(): Add check to quiet down static code checkers Date: Thu, 10 Mar 2016 01:42:06 +0800 Message-ID: <56E0606E.5000906@suse.com> References: <1457458252-20203-1-git-send-email-Jes.Sorensen@redhat.com> <1457458252-20203-5-git-send-email-Jes.Sorensen@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1457458252-20203-5-git-send-email-Jes.Sorensen@redhat.com> Sender: linux-raid-owner@vger.kernel.org To: Jes.Sorensen@redhat.com, linux-raid@vger.kernel.org Cc: neilb@suse.de, pawel.baldysiak@intel.com List-Id: linux-raid.ids On 03/09/2016 01:30 AM, Jes.Sorensen@redhat.com wrote: > From: Jes Sorensen > > Grow_addbitmap() is only ever called with s->bitmap_file != NULL, but > not all static code checkers catch this. This adds a check to quiet > down the false positive warnings. > > Signed-off-by: Jes Sorensen > --- > Grow.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/Grow.c b/Grow.c > index 0fa776d..c453eb6 100755 > --- a/Grow.c > +++ b/Grow.c > @@ -297,7 +297,14 @@ int Grow_addbitmap(char *devname, int fd, struct context *c, struct shape *s) > " between different architectures. Consider upgrading the Linux kernel.\n"); > } > > - if (s->bitmap_file && strcmp(s->bitmap_file, "clustered") == 0) > + /* > + * We only ever get called if s->bitmap_file is != NULL, so this check > + * is just here to quiet down static code checkers. > + */ > + if (!s->bitmap_file) > + return 1; Is it really need to make all static code checkers happy? ;-) Otherwise, I would prefer remove above check. Anyway, I am fine with the changes. Thanks, Guoqing > + > + if (strcmp(s->bitmap_file, "clustered") == 0) > major = BITMAP_MAJOR_CLUSTERED; > > if (ioctl(fd, GET_BITMAP_FILE, &bmf) != 0) {