Re: [PATCH] md: raid5: add prerequisite to run underneath dm-raid

[Heinz Mauelshagen <heinzm@redhat.com>]

On 05/09/2016 10:47 PM, Jes Sorensen wrote:
> heinzm@redhat.com writes:
>> From: Heinz Mauelshagen <heinzm@redhat.com>
>>
>> In case md runs underneath the dm-raid target, the mddev does not have
>> a request queue or gendisk, thus avoid accesses.
>>
>> This patch adds a missing conditional to the raid5 personality.
>>
>>
>> Signed-of-by: Heinz Mauelshagen <heinzm@redhat.com>
>>
>>
>> ---
>>   drivers/md/raid5.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
>> index 8ab8b65..ce79ce6 100644
>> --- a/drivers/md/raid5.c
>> +++ b/drivers/md/raid5.c
>> @@ -7574,8 +7574,10 @@ static void raid5_finish_reshape(struct mddev *mddev)
>>   
>>   		if (mddev->delta_disks > 0) {
>>   			md_set_array_sectors(mddev, raid5_size(mddev, 0, 0));
>> -			set_capacity(mddev->gendisk, mddev->array_sectors);
>> -			revalidate_disk(mddev->gendisk);
>> +			if (mddev->queue) {
>> +				set_capacity(mddev->gendisk, mddev->array_sectors);
>> +				revalidate_disk(mddev->gendisk);
>> +			}
> Since we're in the code taste mode, this is a reminder that kernel code
> is 80 characters per line :)

Hehe, gotta shorten > 20 lines in raid5.c alone then :-)

Heinz

>
> Jes