Linux RAID subsystem development
 help / color / mirror / Atom feed
From: Nominal Animal <kernel@nominal-animal.net>
To: Shaohua Li <shli@kernel.org>,
	linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] md/bitmap.c:bitmap_status(): Fix filename escaping
Date: Mon, 30 May 2016 21:00:19 +0300	[thread overview]
Message-ID: <574C7FB3.50304@nominal-animal.net> (raw)

The call to seq_file_path() does not include backslash itself
in the set of file names escaped. This results in files named
"foo\t-\nbar" and "foo\\011-\\012bar" being both shown
as "foo\\011-\\012bar". Fix this by including backslash
in the escaped set.

diff -Nabpur linux-4.6/drivers/md/bitmap.c linux-new/drivers/md/bitmap.c
--- linux-4.6/drivers/md/bitmap.c	2016-05-16 01:43:13.000000000 +0300
+++ linux-new/drivers/md/bitmap.c	2016-05-30 19:56:43.791298226 +0300
@@ -1928,7 +1928,7 @@ void bitmap_status(struct seq_file *seq,
 		   chunk_kb ? "KB" : "B");
 	if (bitmap->storage.file) {
 		seq_printf(seq, ", file: ");
-		seq_file_path(seq, bitmap->storage.file, " \t\n");
+		seq_file_path(seq, bitmap->storage.file, " \t\n\\");
 	}

 	seq_printf(seq, "\n");

Regards,
  Nominal Animal

                 reply	other threads:[~2016-05-30 18:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574C7FB3.50304@nominal-animal.net \
    --to=kernel@nominal-animal.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox