From: Guoqing Jiang <jgq516@gmail.com>
To: NeilBrown <neilb@suse.com>, Guoqing Jiang <gqjiang@suse.com>,
Shaohua Li <shli@kernel.org>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 3/3] MD: hold mddev lock for md-cluster receive thread
Date: Wed, 3 Aug 2016 11:42:52 +0800 [thread overview]
Message-ID: <57A1683C.5020807@gmail.com> (raw)
In-Reply-To: <87shumpvbd.fsf@notabene.neil.brown.name>
On 08/03/2016 08:09 AM, NeilBrown wrote:
> On Tue, Aug 02 2016, Guoqing Jiang wrote:
>>> Does it work if we move the mddev lock to
>>> process_recvd_msg?
>> I tried that, but It still have lock issue, eg, when node B and C have
>> status
>> as "resync=PENDING", then try to stop the resyncing array in node A.
>>
> Maybe the reconfig_mutex locking needs to go down in
> process_suspend_info() ?? That is the only part that calls quiesce.
Yes, but with this change, I still have lock issue for below steps:
1. create a resyning array in nodeA
2. Assemble the array in node B and nodeC
I can see A can't continue perform resync while C can't assemble
array successfully.
Thanks,
Guoqing
next prev parent reply other threads:[~2016-08-03 3:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-30 23:54 [PATCH 1/3] MD: hold mddev lock for .quiesce in md_do_sync shli
2016-07-30 23:54 ` [PATCH 2/3] MD: hold mddev lock to change bitmap location shli
2016-08-03 0:03 ` NeilBrown
2016-07-30 23:54 ` [PATCH 3/3] MD: hold mddev lock for md-cluster receive thread shli
2016-08-01 8:38 ` Guoqing Jiang
2016-08-01 21:45 ` Shaohua Li
2016-08-02 9:52 ` Guoqing Jiang
2016-08-02 22:44 ` Shaohua Li
2016-08-03 3:18 ` Guoqing Jiang
2016-08-03 0:09 ` NeilBrown
2016-08-03 3:42 ` Guoqing Jiang [this message]
2016-07-31 6:03 ` [PATCH 1/3] MD: hold mddev lock for .quiesce in md_do_sync yizhan
2016-08-02 23:47 ` NeilBrown
2016-08-04 3:16 ` NeilBrown
2016-08-06 4:14 ` Shaohua Li
2016-08-12 0:04 ` NeilBrown
2016-08-17 1:28 ` Shaohua Li
2016-08-24 4:49 ` NeilBrown
2016-08-24 5:25 ` Shaohua Li
2016-08-25 4:59 ` NeilBrown
2016-08-25 17:17 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57A1683C.5020807@gmail.com \
--to=jgq516@gmail.com \
--cc=gqjiang@suse.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=shli@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).