From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guoqing Jiang Subject: Re: [PATCH 08/16] md/bitmap: Rename a jump label in location_store() Date: Wed, 28 Sep 2016 23:16:01 -0400 Message-ID: <57EC8771.3000700@suse.com> References: <566ABCD9.1060404@users.sourceforge.net> <30938c84-20a7-0f13-bdda-a2d2109a6dac@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: kernel-janitors-owner@vger.kernel.org To: Jes Sorensen , SF Markus Elfring Cc: linux-raid@vger.kernel.org, Shaohua Li , LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: linux-raid.ids On 09/28/2016 03:55 PM, Jes Sorensen wrote: > SF Markus Elfring writes: >> From: Markus Elfring >> Date: Tue, 27 Sep 2016 15:46:22 +0200 >> >> Adjust jump labels according to the current Linux coding style convention. >> >> Signed-off-by: Markus Elfring >> --- >> drivers/md/bitmap.c | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) > Sorry but this patch is just plain ridiculous. It does not improve the > code in any shape or form. > > 'out' as a label is perfectly legitimate and just as good as 'unlock'. Agree, I also curious which document recorded the coding style convention. Thanks, Guoqing