From: Wols Lists <antlists@youngman.org.uk>
To: Mariusz Dabrowski <mariusz.dabrowski@intel.com>,
linux-raid@vger.kernel.org
Cc: jes.sorensen@redhat.com
Subject: Re: [PATCH] Use disk sector size value to set offset for reading GPT
Date: Tue, 13 Dec 2016 16:38:51 +0000 [thread overview]
Message-ID: <5850241B.8030007@youngman.org.uk> (raw)
In-Reply-To: <1481195595-13140-1-git-send-email-mariusz.dabrowski@intel.com>
On 08/12/16 11:13, Mariusz Dabrowski wrote:
> mdadm is using invalid byte-offset while reading GPT header to get
> partition info (size, first sector, last sector etc.). Now this offset
> is hardcoded to 512 bytes and it is not valid for disks with sector
> size different than 512 bytes because MBR and GPT headers are aligned
> to LBA, so valid offset for 4k drives is 4096 bytes.
>
> Signed-off-by: Mariusz Dabrowski <mariusz.dabrowski@intel.com>
Could this be behind the couple of incidents recently, where an array
has been moved from one machine to another, and the GPT has disappeared?
I know I've been following the threads, and I've been puzzled in that
I've thought "nothing should be writing there!"
If it is, what mdadm/kernels are affected, and I can put it on the wiki,
writing the page up about corrupted disks is next on my list.
Cheers,
Wol
next prev parent reply other threads:[~2016-12-13 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 11:13 [PATCH] Use disk sector size value to set offset for reading GPT Mariusz Dabrowski
2016-12-12 19:26 ` Jes Sorensen
2016-12-13 16:38 ` Wols Lists [this message]
2016-12-14 11:04 ` Mariusz Dabrowski
2016-12-14 18:38 ` Wols Lists
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5850241B.8030007@youngman.org.uk \
--to=antlists@youngman.org.uk \
--cc=jes.sorensen@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=mariusz.dabrowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).