From: Wols Lists <antlists@youngman.org.uk>
To: Ming Lei <tom.leiming@gmail.com>, Arnd Bergmann <arnd@arndb.de>
Cc: Shaohua Li <shli@kernel.org>, NeilBrown <neilb@suse.com>,
Jens Axboe <axboe@fb.com>, "colyli@suse.de" <colyli@suse.de>,
Guoqing Jiang <gqjiang@suse.com>,
Mike Christie <mchristi@redhat.com>,
"open list:SOFTWARE RAID (Multiple Disks) SUPPORT"
<linux-raid@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "md: raid1: use bio helper in process_checks()"
Date: Tue, 28 Mar 2017 16:43:07 +0100 [thread overview]
Message-ID: <58DA848B.7030308@youngman.org.uk> (raw)
In-Reply-To: <CACVXFVMWORnxVtuokRp=N1ELAk4UbkOr0n-hM2MOTbO7HLhLtw@mail.gmail.com>
On 28/03/17 16:02, Ming Lei wrote:
>> What I meant is that a future change to the function might cause
>> > another bug to go unnoticed later.
> What is the future change? And what is another bug? Please don't suppose or
> assume anything in future.
What was that about some American General demanding a list of "unknown
unknowns"?
>
> BTW, I don't think it is a problem, and anyone who want to change the code
> much should understand it first, right?
>
I'm very sorry, but I think you are assuming facts not in evidence (or
rather, facts that the evidence says are wrong).
In real life, it is normal for people to change things without
understanding them. Are you saying that *you* - a couple of years down
the line - will remember this bit of code, and will block a mistaken patch?
What Arnd is doing is commonly called "defensive programming", and
unfortunately reality shows us that it is usually worth its weight in
gold. That's why you put ASSERTs in code - so that if somebody does
something stupid by accident, it blows up. This is just more of the same.
Cheers,
Wol
next prev parent reply other threads:[~2017-03-28 15:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 9:49 [PATCH] Revert "md: raid1: use bio helper in process_checks()" Arnd Bergmann
2017-03-28 10:44 ` Ming Lei
2017-03-28 11:35 ` Arnd Bergmann
2017-03-28 11:42 ` Ming Lei
2017-03-28 13:20 ` Arnd Bergmann
2017-03-28 15:02 ` Ming Lei
2017-03-28 15:37 ` Arnd Bergmann
2017-03-28 16:13 ` Ming Lei
2017-03-28 15:43 ` Wols Lists [this message]
2017-04-01 21:51 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58DA848B.7030308@youngman.org.uk \
--to=antlists@youngman.org.uk \
--cc=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=colyli@suse.de \
--cc=gqjiang@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mchristi@redhat.com \
--cc=neilb@suse.com \
--cc=shli@kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).