Re: [PATCH] md.c:didn't unlock the mddev before return EINVAL in array_size_store

[Guoqing Jiang <gqjiang@suse.com>]

On 04/10/2017 02:15 PM, Zhilong Liu wrote:
> md.c: it needs to release the mddev lock before
> the array_size_store() returns.

Fixes: ab5a98b132fd ("md-cluster: change array_sectors and update size 
are not supported")

>
> Signed-off-by: Zhilong Liu <zlliu@suse.com>
> ---
>   drivers/md/md.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index f6ae1d6..5327236 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -4843,8 +4843,10 @@ array_size_store(struct mddev *mddev, const char *buf, size_t len)
>   		return err;
>   
>   	/* cluster raid doesn't support change array_sectors */
> -	if (mddev_is_clustered(mddev))
> +	if (mddev_is_clustered(mddev)) {
> +		mddev_unlock(mddev);
>   		return -EINVAL;
> +	}

Reviewed-by: Guoqing Jiang <gqjiang@suse.com>

Thanks,
Guoqing