Re: [PATCH] md/raid10: skip spare disk as 'first' disk

[Guoqing Jiang <gqjiang@suse.com>]

On 05/02/2017 03:22 AM, Shaohua Li wrote:
> Commit 6f287ca(md/raid10: reset the 'first' at the end of loop) ignores
> a case in reshape, the first rdev could be a spare disk, which shouldn't
> be accounted as the first disk since it doesn't include the offset info.

Acked-by: Guoqing Jiang <gqjiang@suse.com>

Thanks,
Guoqing

> Fix: 6f287ca(md/raid10: reset the 'first' at the end of loop)
> Cc: Guoqing Jiang <gqjiang@suse.com>
> Cc: NeilBrown <neilb@suse.com>
> Signed-off-by: Shaohua Li <shli@fb.com>
> ---
>   drivers/md/raid10.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 2883b72..cce23be 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -4079,8 +4079,8 @@ static int raid10_start_reshape(struct mddev *mddev)
>   				diff = 0;
>   			if (first || diff < min_offset_diff)
>   				min_offset_diff = diff;
> +			first = 0;
>   		}
> -		first = 0;
>   	}
>   
>   	if (max(before_length, after_length) > min_offset_diff)